- Added start menu shortcut creation when the app opens

- Removed the code that tried to validate the code signature, as it was causing errors with package managers

- UI & Code enhancements

Author: IgorMundstein

src/App.xaml.cs

@@ -5,7 +5,6 @@
 using System.Globalization;
 using System.IO;
 using System.Linq;
-using System.Reflection;
 using System.Security.Principal;
 using System.ServiceProcess;
 using System.Threading;
@@ -163,19 +162,34 @@ protected virtual void Dispose(bool disposing)
 
         #region Methods
 
-        private void Initialize()
+        /// <summary>
+        /// Creates the start menu shortcut.
+        /// </summary>
+        private void CreateStartMenuShortcut()
         {
-            // Check if the app is secure to run
-            SecurityCheck();
+            try
+            {
+                Helper.CreateShortcut(Path, System.IO.Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.Programs), Constants.App.Shortcut), Constants.App.Title);
+            }
+            catch (Exception e)
+            {
+                Logger.Debug("Failed to create Start Menu shortcut: " + e.GetMessage());
+            }
+        }
 
+        private void Initialize()
+        {
             // DI/IOC
             DependencyInjection.Container.Register<IComputerService, ComputerService>();
             DependencyInjection.Container.Register<IHotkeyService, HotkeyService>();
             DependencyInjection.Container.Register<INotificationService, NotificationService>();
 
             // App properties
-            Path = System.IO.Path.Combine(AppDomain.CurrentDomain.BaseDirectory, AppDomain.CurrentDomain.FriendlyName);
-            Version = Assembly.GetExecutingAssembly().GetName().Version;
+            Path = Helper.GetExecutablePath();
+            Version = Helper.GetVersion();
+
+            // App startup shortcut
+            CreateStartMenuShortcut();
 
             // Check if app is already running
             bool createdNew;
@@ -723,28 +737,6 @@ public static void RunOnStartup(bool enable)
             }
         }
 
-        /// <summary>
-        /// Verify if the app is secure to run
-        /// </summary>
-        private void SecurityCheck()
-        {
-            if (IsInDebugMode)
-                return;
-
-            if (!Validator.IsCertificateValid())
-            {
-                try
-                {
-                    ShowDialog(Localizer.String.SecurityWarning, MessageBoxButton.OK, MessageBoxImage.Warning);
-                    Navigate(Constants.App.Repository.DownloadUri);
-                }
-                finally
-                {
-                    Shutdown(true);
-                }
-            }
-        }
-
         /// <summary>
         /// Sets the app priority for the Windows
         /// </summary>

src/Core/Constants.cs

@@ -20,6 +20,7 @@ public static class App
             public const string License = "GPL-3.0";
             public const string LocalizationResourcePath = EmbeddedResourcePath + "Localization.";
             public const string Name = "WinMemoryCleaner";
+            public const string Shortcut = "Windows Memory Cleaner.lnk";
             public const string ThemesResourcePath = EmbeddedResourcePath + "Themes.";
             public const string Title = "Windows Memory Cleaner";
             public const string VersionFormat = "{0}.{1}.{2}";

src/Core/Helper.cs

@@ -3,6 +3,7 @@
 using System.IO;
 using System.Linq.Expressions;
 using System.Reflection;
+using System.Runtime.InteropServices.ComTypes;
 using System.Text;
 using System.Web.Script.Serialization;
 
@@ -26,18 +27,22 @@ private static void AppendIndent(StringBuilder sb, int level, string indent)
         }
 
         /// <summary>
-        /// Creates a directory exists. Ignores failures.
+        /// Creates a shortcut (.lnk) at the specified path pointing to the target executable.
         /// </summary>
-        public static void CreateDirectory(string path)
+        /// <param name="targetExePath">The full path to the .exe file.</param>
+        /// <param name="destinationLinkPath">The full path where the .lnk file will be saved.</param>
+        /// <param name="description">The tooltip description for the shortcut.</param>
+        public static void CreateShortcut(string targetExePath, string destinationLinkPath, string description)
         {
-            try
-            {
-                if (!string.IsNullOrEmpty(path) && !Directory.Exists(path))
-                    Directory.CreateDirectory(path);
-            }
-            catch
-            {
-            }
+            var link = (ShellInterop.IShellLink)new ShellInterop.ShellLink();
+
+            link.SetDescription(description);
+            link.SetPath(targetExePath);
+            link.SetWorkingDirectory(Path.GetDirectoryName(targetExePath));
+
+            IPersistFile file = (IPersistFile)link;
+
+            file.Save(destinationLinkPath, false);
         }
 
         /// <summary>
@@ -144,25 +149,22 @@ private static string FormatJson(string json)
         }
 
         /// <summary>
-        /// Gets the current application's assembly version.
+        /// Returns the executable application's path
         /// </summary>
-        public static Version GetCurrentVersion()
+        public static string GetExecutablePath()
         {
             try
             {
-                return (Assembly.GetEntryAssembly() ?? Assembly.GetExecutingAssembly()).GetName().Version ?? new Version(0, 0, 0, 0);
+                var path = Process.GetCurrentProcess().MainModule.FileName;
+
+                if (!string.IsNullOrEmpty(path) && File.Exists(path))
+                    return path;
             }
-            catch
+            catch 
             {
-                return new Version(0, 0, 0, 0);
+                // ignored
             }
-        }
 
-        /// <summary>
-        /// Returns the executable path of the current process.
-        /// </summary>
-        public static string GetExecutablePath()
-        {
             try
             {
                 var entry = Assembly.GetEntryAssembly();
@@ -172,15 +174,24 @@ public static string GetExecutablePath()
             }
             catch
             {
+                // ignored
             }
 
+            return Path.Combine(AppDomain.CurrentDomain.BaseDirectory, AppDomain.CurrentDomain.FriendlyName);
+        }
+
+        /// <summary>
+        /// Gets the application's assembly version
+        /// </summary>
+        public static Version GetVersion()
+        {
             try
             {
-                return Process.GetCurrentProcess().MainModule.FileName;
+                return (Assembly.GetEntryAssembly() ?? Assembly.GetExecutingAssembly()).GetName().Version ?? new Version(0, 0, 0, 0);
             }
             catch
             {
-                return Path.Combine(AppDomain.CurrentDomain.BaseDirectory, AppDomain.CurrentDomain.FriendlyName);
+                return new Version(0, 0, 0, 0);
             }
         }
 

src/Core/Updater.cs

@@ -85,14 +85,13 @@ private static void OnVersionCheckCompleted(object sender, DownloadStringComplet
                     return;
                 }
 
-                var exe = AppDomain.CurrentDomain.FriendlyName;
-                var path = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, exe);
+                var exe = Path.GetFileName(App.Path);
                 var temp = Path.Combine(Path.GetTempPath(), exe);
 
                 if (File.Exists(temp))
                     File.Delete(temp);
 
-                var updateInfo = Tuple.Create(temp, path, exe, newestVersion, (string[])e.UserState);
+                var updateInfo = Tuple.Create(temp, App.Path, exe, newestVersion, (string[])e.UserState);
 
                 _client.DownloadFileAsync(Constants.App.Repository.LatestExeUri, temp, updateInfo);
             }

src/Core/Validator.cs

@@ -0,0 +1,51 @@
+using System;
+using System.Runtime.InteropServices;
+using System.Text;
+
+namespace WinMemoryCleaner
+{
+    /// <summary>
+    /// Windows Shell API
+    /// </summary>
+    internal static class ShellInterop
+    {
+        #region Classes
+
+        [ComImport]
+        [Guid("00021401-0000-0000-C000-000000000046")]
+        internal class ShellLink
+        {
+        }
+
+        #endregion
+
+        #region Interfaces
+
+        [ComImport]
+        [Guid("000214F9-0000-0000-C000-000000000046")]
+        [InterfaceType(ComInterfaceType.InterfaceIsIUnknown)]
+        internal interface IShellLink
+        {
+            void GetPath([Out, MarshalAs(UnmanagedType.LPWStr)] StringBuilder pszFile, int cch, out IntPtr pfd, int fFlags);
+            void GetIDList(out IntPtr ppidl);
+            void SetIDList(IntPtr pidl);
+            void GetDescription([Out, MarshalAs(UnmanagedType.LPWStr)] StringBuilder pszName, int cch);
+            void SetDescription([MarshalAs(UnmanagedType.LPWStr)] string pszName);
+            void GetWorkingDirectory([Out, MarshalAs(UnmanagedType.LPWStr)] StringBuilder pszDir, int cch);
+            void SetWorkingDirectory([MarshalAs(UnmanagedType.LPWStr)] string pszDir);
+            void GetArguments([Out, MarshalAs(UnmanagedType.LPWStr)] StringBuilder pszArgs, int cch);
+            void SetArguments([MarshalAs(UnmanagedType.LPWStr)] string pszArgs);
+            void GetHotkey(out short pwHotkey);
+            void SetHotkey(short wHotkey);
+            void GetShowCmd(out int piShowCmd);
+            void SetShowCmd(int iShowCmd);
+            void GetIconLocation([Out, MarshalAs(UnmanagedType.LPWStr)] StringBuilder pszIconPath, int cch, out int piIcon);
+            void SetIconLocation([MarshalAs(UnmanagedType.LPWStr)] string pszIconPath, int iIcon);
+            void SetRelativePath([MarshalAs(UnmanagedType.LPWStr)] string pszPathRel, int dwReserved);
+            void Resolve(IntPtr hwnd, int fFlags);
+            void SetPath([MarshalAs(UnmanagedType.LPWStr)] string pszFile);
+        }
+
+        #endregion
+    }
+}

src/Core/NativeMethods.cs src/Interop/NativeMethods.cssrc/Core/NativeMethods.cs renamed to src/Interop/NativeMethods.cs

@@ -27,7 +27,7 @@ public class Localization
         private string _optimizationHotkey, _optimize, _optimizeOnMiddleMouseClick, _optimizing;
         private string _physicalMemory, _processExclusionList;
         private string _reason, _registryCache, _remove, _reset, _resetConfirmation, _runOnLowPriority, _runOnStartup;
-        private string _schedule, _seconds, _securityWarning, _settings, _showMemoryUsage, _showOptimizationNotifications, _showVirtualMemory, _standbyList, _standbyListLowPriority, _startMinimized, _systemFileCache;
+        private string _schedule, _seconds, _settings, _showMemoryUsage, _showOptimizationNotifications, _showVirtualMemory, _standbyList, _standbyListLowPriority, _startMinimized, _systemFileCache;
         private string _text, _trayIcon;
         private string _updatedToVersion, _used, _useTransparentBackground;
         private string _virtualMemory;
@@ -402,13 +402,6 @@ public string Seconds
             private set { _seconds = value.Capitalize(); }
         }
 
-        [DataMember]
-        public string SecurityWarning
-        {
-            get { return _securityWarning; }
-            private set { _securityWarning = value.Capitalize(); }
-        }
-
         [DataMember]
         public string Settings
         {

src/Interop/ShellInterop.cs

@@ -11,7 +11,7 @@
 [assembly: AssemblyKeyFile(Constants.App.KeyFile)]
 [assembly: AssemblyProduct(Constants.App.Name)]
 [assembly: AssemblyTitle(Constants.App.Title)]
-[assembly: AssemblyVersion("3.0.6.0")]
+[assembly: AssemblyVersion("3.0.7.0")]
 [assembly: ComVisible(false)]
 [assembly: CLSCompliant(true)]
 [assembly: Guid(Constants.App.Id)]

src/Model/Localization.cs

@@ -51,7 +51,6 @@
   "RunOnStartup": "vazhdo në fillim",
   "Schedule": "orari",
   "Seconds": "sekonda",
-  "SecurityWarning": "ky aplikacion mund të jetë manipuluar. do të ridrejtoheni në depozitat zyrtare për të shkarkuar një version të sigurt.",
   "Settings": "cilësimet",
   "ShowMemoryUsage": "shfaq përdorimin e memories",
   "ShowOptimizationNotifications": "shfaq njoftimet e optimizimit",