Skip to content

Commit bbffd73

Browse files
Enforce ruff/flynt rule FLY002 (#291)
FLY002 Consider f-string instead of string join
1 parent b5a9cc9 commit bbffd73

3 files changed

Lines changed: 6 additions & 9 deletions

File tree

src/highdicom/content.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ def __init__(
8686
item.AlgorithmSource = source
8787
if parameters is not None:
8888
item.AlgorithmParameters = ','.join([
89-
'='.join([key, value])
89+
f"{key}={value}"
9090
for key, value in parameters.items()
9191
])
9292
self.append(item)

src/highdicom/sr/value_types.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1876,13 +1876,10 @@ def __init__(
18761876
]
18771877
else:
18781878
raise ValueError(
1879-
'One of the following arguments is required: "{}"'.format(
1880-
'", "'.join([
1881-
'referenced_sample_positions',
1882-
'referenced_time_offsets',
1883-
'referenced_date_time'
1884-
])
1885-
)
1879+
'One of the following arguments is required: '
1880+
'"referenced_sample_positions", '
1881+
'"referenced_time_offsets", '
1882+
'"referenced_date_time"'
18861883
)
18871884

18881885
@property

tests/test_seg.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def test_construction_optional_argument_2(self):
129129
assert len(seq) == 1
130130
item = seq[0]
131131
parsed_params = ','.join([
132-
'='.join([key, value])
132+
f'{key}={value}'
133133
for key, value in self._parameters.items()
134134
])
135135
assert item.AlgorithmParameters == parsed_params

0 commit comments

Comments
 (0)