Remove SOPClass "copy" methods from docs, add notes#385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two "copy" method on the
SOPClassclass (copy_patient_and_study_informationandcopy_specimen_information) should really be considered "private" methods used only by those writing sub-classes ofSOPClass. However currently they appear as methods on all sub-classes, which is confusing and at least some people are using it when they shouldn't (e.g. #384 ).Since they date back to the beginning of the library, we will wait for a major version to make them truly private. In the meantime, this PR: