Volume dtype restriction#409
Closed
mccle wants to merge 8 commits into
Closed
Conversation
Add import_optional_dependency util function
* Remove packaging version specifier * Update packaging dependency version in pyproject.toml --------- Co-authored-by: Mason C. Cleveland <104479423+mccle@users.noreply.github.com>
* Add import_optional_dependency util function * Update optional import function. * Reformat code * Add module version compatibility check. * Move version incompatibility error raise location and update error message * Update src/highdicom/utils.py Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com> * Update src/highdicom/utils.py Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com> * Update src/highdicom/utils.py Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com> * Update src/highdicom/utils.py Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com> * Update src/highdicom/utils.py Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com> * Move to new utils file * Add packaging to requirements * add itk and sitk conversions * Add frame_of_reference_uid and coordinate_system arguments; update docstrings; reformat strings * remove channel argument * add noqa to work with flake8 * update type hints, minor tweaks to bool retyping * sync changes * flake8 * Add tests for sitk * flake8 * skip sitk test on failed import * fix url syntax * Fix itk conversion and add tests * Update .github/workflows/run_unit_tests.yml Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com> * Replace common url elements * Update docstrings and error messages * Update volume docs file * Update dtype tests with array equality and random values * Apply suggestion from @CPBridge Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com> * Reorganize and update docs files * Update docstrings * Fix multichannel check and add tests --------- Co-authored-by: Chris Bridge <chrisbridge44@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added checks to the volume init and setter methods to ensure volumes have float, integer, or bool types. A new test was added to verify that volumes cannot be instantiated with an array of an unsupported data type nor changed after instantiation to a new data type that is unsupported.