Merged
Conversation
rswinkle
suggested changes
Apr 25, 2026
RobLoach
commented
Apr 27, 2026
|
|
||
| /* filled background bar style */ | ||
| fill.w = visual_cursor->x+ 0.5*visual_cursor->w - bar.x; | ||
| fill.w = visual_cursor->x+ 0.5f*visual_cursor->w - bar.x; |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| fill.w = visual_cursor->x+ 0.5f*visual_cursor->w - bar.x; | |
| fill.w = visual_cursor->x + 0.5f * visual_cursor->w - bar.x; |
Contributor
There was a problem hiding this comment.
Personally prefer spaces on either side of every operator, but 🤷 ... What is represented elsewhere?
I think my natural tendency is to use no spaces to represent mental groupings to make it easier to read. I feel like longer expressions get harder to read if you use spaces everywhere and occasional tight couplings help you parse it better/more quickly, without the mess of unnecessary parenthesis.
But yes, I think spaces everywhere is more consistent with Nuklear's codebase in general, and for this function/file at the very least, so I think we're good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix for visual_cursor type conversion.