Skip to content

slider: Fix float type conversion #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobLoach merged 3 commits into from
Apr 28, 2026
Merged

slider: Fix float type conversion #948

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c82bebc
slider: Fix float type conversion
RobLoach Apr 23, 2026
1039f28
Update src/nuklear_slider.c
RobLoach Apr 27, 2026
9950249
Fix spacing in fill width calculation
RobLoach Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nuklear.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25958,7 +25958,7 @@ nk_draw_slider(struct nk_command_buffer *out, nk_flags state,
bar.h = style->bar_height;

/* filled background bar style */
fill.w = visual_cursor->x+ 0.5*visual_cursor->w - bar.x;
fill.w = visual_cursor->x+ 0.5f*visual_cursor->w - bar.x;
Copy link
Copy Markdown
Contributor Author

@RobLoach RobLoach Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fill.w = visual_cursor->x+ 0.5f*visual_cursor->w - bar.x;
fill.w = visual_cursor->x + 0.5f * visual_cursor->w - bar.x;

Copy link
Copy Markdown
Contributor

@rswinkle rswinkle Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally prefer spaces on either side of every operator, but 🤷 ... What is represented elsewhere?

I think my natural tendency is to use no spaces to represent mental groupings to make it easier to read. I feel like longer expressions get harder to read if you use spaces everywhere and occasional tight couplings help you parse it better/more quickly, without the mess of unnecessary parenthesis.

But yes, I think spaces everywhere is more consistent with Nuklear's codebase in general, and for this function/file at the very least, so I think we're good.

fill.x = bar.x;
fill.y = bar.y;
fill.h = bar.h;
Expand Down
2 changes: 1 addition & 1 deletion src/nuklear_slider.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ nk_draw_slider(struct nk_command_buffer *out, nk_flags state,
bar.h = style->bar_height;

/* filled background bar style */
fill.w = visual_cursor->x+ 0.5*visual_cursor->w - bar.x;
fill.w = visual_cursor->x+ 0.5f*visual_cursor->w - bar.x;
Comment thread
RobLoach marked this conversation as resolved.
Outdated
fill.x = bar.x;
fill.y = bar.y;
fill.h = bar.h;
Expand Down
Loading