feat: config inclusion#955
Open
sleeptightAnsiC wants to merge 2 commits into
Open
Conversation
sleeptightAnsiC
marked this pull request as draft
May 7, 2026 21:09
sleeptightAnsiC
commented
May 7, 2026
sleeptightAnsiC
force-pushed
the
feat_user_config
branch
2 times, most recently
from
May 8, 2026 20:54
3acb495 to
e146fe5
Compare
sleeptightAnsiC
changed the title
sleeptightAnsiC
force-pushed
the
feat_user_config
branch
from
May 8, 2026 21:20
e146fe5 to
9adb7b1
Compare
sleeptightAnsiC
marked this pull request as ready for review
May 8, 2026 21:23
sleeptightAnsiC
commented
May 11, 2026
sleeptightAnsiC
force-pushed
the
feat_user_config
branch
2 times, most recently
from
May 12, 2026 08:43
9ba68d1 to
ab3b09c
Compare
sleeptightAnsiC
changed the title
RobLoach
requested changes
May 12, 2026
sleeptightAnsiC
marked this pull request as draft
May 31, 2026 20:07
This comment was marked as resolved.
This comment was marked as resolved.
sleeptightAnsiC
force-pushed
the
feat_user_config
branch
3 times, most recently
from
May 31, 2026 23:10
0ad44bc to
62c16ab
Compare
sleeptightAnsiC
marked this pull request as ready for review
May 31, 2026 23:36
Contributor
Author
|
Just beware I snuck another commit into this PR that just rewords one comment. I was already touching this exact code and it was harmless. It's related to request from #961 (don't squash it though) |
RobLoach
reviewed
Jun 29, 2026
Adds a way to inject config header with predefined macros and includes. This is not so important for regular users of amalgamated ./nuklear.h but becomes useful when building from ./src/*.c with actual build system See linked issue for more details and reasoning about this. Resolves: Immediate-Mode-UI#886
Origin: Immediate-Mode-UI#961 (comment) Fixes: Immediate-Mode-UI#961 Co-authored-by: TomJGooding <101601846+TomJGooding@users.noreply.github.com>
sleeptightAnsiC
force-pushed
the
feat_user_config
branch
from
June 30, 2026 13:55
ef02370 to
8362119
Compare
sleeptightAnsiC
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #886
See linked issue and commit message for more details and reasoning.
I found this to be a rather good moment to submit this feature as I was updating some of my private repos with it. Also I'm planning to share some code that reuses
demo/sdl3_rendererwith differentmain.cfor the purpose of #726 (comment) and #888 (comment), and having its config split into another file will be helpful there.