Skip to content

Hidden should only be used if not-configurable#327

Merged
viceroypenguin merged 1 commit into
masterfrom
ihr0019
May 4, 2026
Merged

Hidden should only be used if not-configurable#327
viceroypenguin merged 1 commit into
masterfrom
ihr0019

Conversation

@viceroypenguin

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 4, 2026 17:34
@codecov

codecov Bot commented May 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...mediate.Handlers.Analyzers/HandlerClassAnalyzer.cs 97.97% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the default severity of analyzer rule IHR0019 (“Static handler may be converted to a sealed handler”) so it no longer uses Hidden, aligning the rule’s behavior with the stated intent that Hidden should only be used for not-configurable diagnostics.

Changes:

  • Change IHR0019 default severity from Hidden to Info in HandlerClassAnalyzer.
  • Update the shipped analyzer release metadata to reflect IHR0019 as Info.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Immediate.Handlers.Analyzers/HandlerClassAnalyzer.cs Updates IHR0019’s DiagnosticDescriptor default severity to Info.
src/Immediate.Handlers.Analyzers/AnalyzerReleases.Shipped.md Updates the recorded shipped severity for IHR0019 to Info.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants