fix(command): reject legacy embedded LibCommand provider

Author: ImperaZim

CONTRIBUTING.md

@@ -7,7 +7,7 @@ All pull requests should target the `development` branch.
 | Change | Repository |
 |---|---|
 | EasyLibrary core, module system, components, or utility APIs | This repository |
-| A bundled library (e.g., LibCommand, LibForm, LibWorld) | The respective standalone repository |
+| An official library package (e.g., LibCommand, LibForm, LibWorld) | The respective standalone/package repository |
 | Documentation or examples | This repository |
 
 ## Core Contributions
@@ -22,16 +22,18 @@ find src -name '*.php' -print0 | xargs -0 -n1 php -l
 composer validate --strict
 ```
 
-## Bundled Library Changes
+## Official Library Changes
 
-Each bundled library lives in its own standalone repository. Changes to a
-library's source code, API, or behavior should target that repository's
-`development` branch. The EasyLibrary repository mirrors those sources.
+Each official library lives in its own repository. Changes to a library's
+source code, API, or behavior should target that repository's `development`
+branch.
 
-When a change in a standalone library affects EasyLibrary's embedded copy:
+EasyLibrary 3.x does not embed official library source. When a library changes:
 
 1. Open the pull request in the standalone repository first.
-2. After merge, update the embedded source in EasyLibrary to match.
+2. Update package metadata, docs or release assets if EasyLibrary needs to
+   install or describe the new version.
+3. Do not copy library source back into `EasyLibrary/src/imperazim`.
 
 ## Module System
 

README.md

@@ -211,7 +211,7 @@ Standalone installed:
   for the same runtime during mixed mode
   an installed internal package reports installed-shadowed-by-standalone instead of active
 
-Legacy embedded fallback:
+Legacy 2.x full-bundle fallback:
   removed from the EasyLibrary 3.x core
   use EasyLibrary 2.x if a server still depends on full-bundle behavior
 ```
@@ -446,7 +446,7 @@ Runtime states:
 | `standalone-installed-disabled` | A standalone plugin or PHAR was found, but it is not enabled. |
 | `embedded-runtime` | Historical/legacy state from older migration builds. New 3.x core builds do not provide embedded runtimes. |
 | `embedded-classpath` | Historical/legacy state from older migration builds. New 3.x core builds do not provide embedded classpath libs. |
-| `embedded-disabled` | No package/standalone provider is active and the old embedded fallback is not available in 3.x. |
+| `embedded-disabled` | No package/standalone provider is active and the legacy 2.x full-bundle fallback is not available in 3.x. |
 | `duplicate-runtime` | A standalone plugin is active while another provider appears to own the same runtime. This should be fixed. |
 | `missing` | No standalone or package-backed provider is available for that library. |
 

plugin.yml

@@ -47,7 +47,7 @@ permissions:
     description: Inspect EasyLibrary runtime providers
   easylibrary.command.runtime.control:
     default: op
-    description: Enable, disable and reload EasyLibrary-owned embedded runtimes
+    description: Access retired runtime-control compatibility commands
   easylibrary.command.config:
     default: op
     description: Inspect EasyLibrary modular configuration state

src/imperazim/library/command/backend/CommandBackendResolver.php

@@ -7,6 +7,7 @@
 use imperazim\components\plugin\PluginToolkit;
 use imperazim\library\command\provider\CommandClassAvailability;
 use imperazim\library\command\provider\CommandProviderResolver;
+use imperazim\library\command\provider\CommandProviderStatus;
 
 final class CommandBackendResolver {
 
@@ -16,8 +17,12 @@ public function __construct(
     ) {}
 
     public function resolve(): CommandBackend {
-        (new CommandProviderResolver($this->host))->resolve();
-        if (CommandClassAvailability::richCommandsAvailable()) {
+        $provider = (new CommandProviderResolver($this->host))->resolve();
+        if (CommandClassAvailability::richCommandsAvailable() && in_array($provider->getProvider(), [
+            CommandProviderStatus::PACKAGE_BACKED,
+            CommandProviderStatus::PACKAGE_CLASSPATH,
+            CommandProviderStatus::STANDALONE,
+        ], true)) {
             return new LibCommandBackend($this->host, $this->agentManager);
         }
 

src/imperazim/library/command/provider/CommandProviderResolver.php

@@ -40,13 +40,9 @@ public function resolve(): CommandProviderStatus {
         $notes = [];
 
         if ($provider === CommandProviderStatus::EMBEDDED_LEGACY) {
-            if (\LibraryModules::isLegacyEmbeddedEnabled($this->host)) {
-                $warnings[] = 'EasyLibrary internal commands are currently using the embedded legacy LibCommand classes.';
-                $notes[] = 'Do not remove src/imperazim/command until package-backed or standalone LibCommand is guaranteed for command registration.';
-            } else {
-                $notes[] = 'Embedded legacy LibCommand classes were removed from EasyLibrary 3.x.';
-                $notes[] = 'EasyLibrary will use the native recovery command unless package-backed or standalone LibCommand is active.';
-            }
+            $warnings[] = 'LibCommand classes appear to be loaded from the removed EasyLibrary embedded source path.';
+            $notes[] = 'EasyLibrary 3.x does not accept embedded LibCommand as a rich command provider.';
+            $notes[] = 'Install package-backed or standalone LibCommand, then restart.';
         }
         if ($provider === CommandProviderStatus::MISSING) {
             $warnings[] = 'imperazim\\command\\Command is not loaded; EasyLibrary command registration would fail.';
@@ -65,7 +61,7 @@ public function resolve(): CommandProviderStatus {
         } elseif ($plugin instanceof Plugin) {
             $notes[] = 'LibCommand plugin exists but is not recognized as active package-backed or standalone.';
         } else {
-            $notes[] = 'No LibCommand plugin identity is active; EasyLibrary can only rely on embedded command classes right now.';
+            $notes[] = 'No LibCommand plugin identity is active; EasyLibrary will use the native recovery command.';
         }
 
         return new CommandProviderStatus(
@@ -123,7 +119,7 @@ private function hookProvider(): string {
             return 'unavailable';
         }
         if (\imperazim\command\LibCommandHooker::isHostedBy($this->host)) {
-            return 'EasyLibrary embedded hook';
+            return 'legacy EasyLibrary hook';
         }
         if (\imperazim\command\LibCommandHooker::isRegistered()) {
             return 'external LibCommand hook';
@@ -178,7 +174,7 @@ private function embeddedConsumers(): array {
             'Module command tree: imperazim\\module\\command\\*',
             'Default command overrides: imperazim\\library\\command\\override\\PluginsCommand and VersionCommand',
             'PluginToolkit command registration helper: imperazim\\components\\plugin\\PluginToolkit',
-            'Embedded runtime commands while legacy packages exist: LibPlaceholder, LibWorld and Agent Bridge command classes',
+            'External package commands when their package-backed or standalone providers are active',
         ];
     }
 }