fix(ci): validate LibForm against PocketMine API

Author: ImperaZim

.github/scripts/analyse.php

@@ -18,9 +18,6 @@
 }
 
 $phpstan = $root . '/vendor/bin/phpstan';
-if (PHP_OS_FAMILY === 'Windows') {
-    $phpstan .= '.bat';
-}
 
 if (!is_file($phpstan)) {
     echo "PHPStan is not installed; skipping analysis.\n";

.github/workflows/quality.yml

@@ -14,7 +14,7 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
@@ -32,7 +32,7 @@ jobs:
 
       - name: Install Composer dependencies
         if: ${{ hashFiles('composer.json') != '' }}
-        run: composer install --prefer-dist --no-interaction --no-progress
+        run: composer install --prefer-dist --no-interaction --no-progress --ignore-platform-req='ext-*'
 
       - name: Run Composer quality script
         if: ${{ hashFiles('composer.json') != '' }}

CHANGELOG.md

@@ -13,6 +13,16 @@ The format is inspired by Keep a Changelog and uses semantic versioning where po
 - Quality workflow scaffolding.
 - Compatibility and standalone/embedded documentation.
 
+### Changed
+
+- Quality analysis now uses the real PocketMine-MP 5 API instead of unresolved framework types.
+- Form collections now declare their key and value types for static analysis.
+
+### Fixed
+
+- PHPStan now runs correctly through the Composer quality script on Windows.
+- Removed unused persisted constructor state while preserving the public form APIs.
+
 ## [2.0.0] - TBD
 
 ### Notes

composer.json

@@ -12,7 +12,8 @@
         "php": "^8.2"
     },
     "require-dev": {
-        "phpstan/phpstan": "^1.10"
+        "phpstan/phpstan": "^1.10",
+        "pocketmine/pocketmine-mp": "^5.0"
     },
     "scripts": {
         "lint": "@php .github/scripts/lint.php",