Conversation
ACea15
left a comment
ACea15
left a comment
There was a problem hiding this comment.
Thanks Norberto, just a couple of comments and it is good to go into develop. It is still a work in progress but it is self-contained and does not conflict with any part of the code, I believe, so let's merge to develop and keep working from there.
I reckon it could be a very useful feature in production environments and it is not easy to navigate from the nonlinear to the linear part, to then apply sectional corrections on the state-space systems based on the derivatives... so nice work!!
| ### detect bc at node (and no. of dofs) | ||
| bc_here = structure.boundary_conditions[inode] | ||
|
|
||
| if bc_here == 1: # clamp (only rigid-body) |
There was a problem hiding this comment.
On a trim analysis, this very first node with bc=1 would still have DoF, therefore is this routine only valid for A-frame node clamped conditions? It is fine if that's the case but we should remark it at the function docstring.
There was a problem hiding this comment.
The issue with the bc=1 node is that it doesn't have flexible DOF and hence the airforces at that node are not mapped to it but rather to the A frame (i.e. with the sum of all the forces). Therefore, to correct the aero force at the bc=1 node, I subtract all the other forces from the A frame, correct them, and sum them all up again:
sharpy/sharpy/generators/polaraeroforces.py
Line 385 in 684e5c3
Apply revisions from code review
|
Thanks, Alvaro, for the review. I'm seeing if can fix an issue with the tests (running fine from the individual directory but failing from the top-level) and I'll merge this |
3 participants
Supports corrections from polar airfoil data on the linearised aeroelastic system.
Modifications are only made to the lift force at the moment. The forces from the aeroelastic system are projected onto the local stability axis (drag, lift, etc) and a coefficient is applied based on the derivative of the polar data at the linearisation condition. The forces are then projected back onto the original frame.
Full details found in the docstring:
sharpy/sharpy/generators/polaraeroforces.py
Line 219 in eceff9c
@rafapalacios @ACea15 please can you have a look whenever you have a moment? maybe we don't want to merge this just yet or maybe you think its a valuable feature