Externalize tcpdf composer#1684
Draft
fiammybe wants to merge 36 commits into
Draft
Conversation
…t to test thoroughly
…omposer, but that is not yet implemented for HTMLPurifier
Co-authored-by: Raimondas Rimkevičius <github@mekdrop.name>
…unused dev dependencies, and clean up scripts
no license info than the wrong info
the autoloader in the vendor folder.
Use === to compare $entry against '.' and '..' to avoid type coercion and ensure exact string matches.
Return success from copyRecursive and add a recursive flag to getFileCount. When validating vendor copies, verify autoload.php SHA-1 and compare recursive file counts; remove partial copies and return a descriptive error if verification fails.
Apply coding-style cleanup (short array syntax, spacing, brace placement, normalized quotes) and replace the legacy SIMPLEPIE_LOCATOR_NONE with \SimplePie\SimplePie::LOCATOR_NONE.
Determine protocol from HTTPS, default HTTP_HOST to 'localhost' when absent, and examine PHP_SELF, REQUEST_URI (path only), and SCRIPT_NAME for the script path. Sanitize values with htmlentities and fall back to an empty base if no path info is available.
Ensure multi_login is set and equals 1 before writing online. Read $_SERVER['REMOTE_ADDR'] into a safe variable (default empty string) to avoid undefined index notices.
Log when REMOTE_ADDR is empty to help identify environments where it's absent (CLI, proxies, tests). Include uid and uname in the error_log message for easier correlation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This must be done after #1683. There is no use of this functionality in the core, so it is difficult to do a regression test.