fix: correct JSON escaping in Tuta additionalSettings#1435
Open
pratham-jaiswal wants to merge 1 commit into
Open
fix: correct JSON escaping in Tuta additionalSettings#1435pratham-jaiswal wants to merge 1 commit into
pratham-jaiswal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the
additionalSettingsJSON for the Tuta config (de.tutao.tutanota.json)The previous value used invalid escaping for the regex in
versionExtractionRegEx, which caused:This was breaking the build pipeline when
buildData.jsattempted to parse the generated config.Root cause
The regex used
\ddirectly inside a JSON string. SinceadditionalSettingsitself is a stringified JSON object, the backslashes needed to be escaped twice.Changes
versionExtractionRegExJSON.parseVerification
Tested locally:
node buildData.jsnow runs successfullyobtainium://app/...payload from “Add to Obtainium”