Formatting/import optimization doesn't work when something is selected

[InSyncWithFoo]

Originally posted by @igallart in #78:

Hi @InSyncWithFoo,

The command only works when no part of the file is selected.
If any fragment or even the whole file is selected, it doesn’t work.

At first, I thought this only affected import optimizations, but it actually applies to formatting in general, including imports.
This is the log in console log ruff, in idea.log nothing of ruff.

Ruff commands and their outputs will be logged here, when not text selected, with selected nothing show.

Ruff commands and their outputs will be logged here.

Running: (/opt/sources/odoo180) /usr/local/bin/ruff check --fix --fix-only --exit-zero --quiet - --select I,F401 --stdin-filename /opt/sources/odoo180/src/account-analytic/account_analytic_distribution_manual/models/account_analytic_distribution_manual.py --config /opt/sources/dev-tools/helpers/17_18.ruff.toml
Output: {"stdout":"from odoo import fields, models\n\n\nclass AccountAnalyticDistributionManual(models.Model):\n _name = "account.analytic.distribution.manual"\n _inherit = "analytic.mixin"\n _description = "Account analytic distribution manual"\n\n name = fields.Char(required=True)\n active = fields.Boolean(default=True)\n company_id = fields.Many2one(\n "res.company", required=True, default=lambda self: self.env.company\n )\n\n sql_constraints = [\n (\n "unique_name_by_company",\n "unique(name, company_id)",\n "The name must be unique per Company!",\n ),\n ]\n\n def copy_data(self, default=None):\n default = dict(default or {})\n vals_list = super().copy_data(default)\n if "name" not in default:\n for record, vals in zip(self, vals_list, strict=False):\n vals["name"] = self.env.("%s (Copy)", record.name)\n return vals_list\n","stderr":"","exitCode":0,"isTimeout":false,"isCancelled":false}

Running: (/opt/sources/odoo180) /usr/local/bin/ruff check --no-fix --exit-zero --quiet - --output-format json --stdin-filename /opt/sources/odoo180/src/account-analytic/account_analytic_distribution_manual/models/account_analytic_distribution_manual.py --config /opt/sources/dev-tools/helpers/17_18.ruff.toml
Output: {"stdout":"[\n {\n "cell": null,\n "code": "ANN201",\n "end_location": {\n "column": 18,\n "row": 23\n },\n "filename": "/opt/sources/odoo180/src/account-analytic/account_analytic_distribution_manual/models/account_analytic_distribution_manual.py",\n "fix": null,\n "location": {\n "column": 9,\n "row": 23\n },\n "message": "Missing return type annotation for public function copy_data",\n "noqa_row": 23,\n "url": "https://docs.astral.sh/ruff/rules/missing-return-type-undocumented-public-function"\n },\n {\n "cell": null,\n "code": "ANN001",\n "end_location": {\n "column": 32,\n "row": 23\n },\n "filename": "/opt/sources/odoo180/src/account-analytic/account_analytic_distribution_manual/models/account_analytic_distribution_manual.py",\n "fix": null,\n "location": {\n "column": 25,\n "row": 23\n },\n "message": "Missing type annotation for function argument default",\n "noqa_row": 23,\n "url": "https://docs.astral.sh/ruff/rules/missing-type-function-argument"\n }\n]","stderr":"","exitCode":0,"isTimeout":false,"isCancelled":false}

[igallart]

Hi @InSyncWithFoo, I’ve confirmed that it actually affects the imports, when nothing is selected, everything works — formatting and imports. But when something is selected, formatting works (line 17) but imports don’t (line 1.

Grabacion.de.pantalla.desde.2025-08-22.12-38-56.webm

[InSyncWithFoo]

@igallart I'm afraid I can't reproduce the problem. Again, could you create a minimal reproducible example? I'll need to know your settings as well.

[igallart]

Hello, thank you very much for your plugin and for your time. Something like this was definitely needed, and you’re doing a great job 👏.
I’ll try to outline the steps and the necessary information to reproduce the issue.

PyCharm version

Options imports in PyCharm (I don't know if it affects ruff).

Versions of ruff, uv and RyeCharm

ruff     0.12.9
uv       0.8.11
RyeCharm 0.1.0-alpha-16

Ruff options

Sample code for testing

import requests

def test_function():
    a = 'hello'
    print(a)

To avoid confusion or mistakes, I’ll describe the steps directly from the PyCharm menu.

---

Test 1

Nothing selected.
Navigate to: Code > Reformat Code

✅ Result (correct):
The code is formatted properly. It leaves a couple of empty lines before the function, but running reformat again fixes that, so it’s not a big issue.

def test_function():
    a = "hello"
    print(a)

---

Test 2

Entire file selected.
Navigate to: Edit > Select All → Code > Reformat Code

❌ Result (incorrect):
Only the string 'hello' is reformatted to "hello", and an extra blank line is added before the function.
However, the unused import requests is not removed.

import requests


def test_function():
    a = "hello"
    print(a)

Need more information? Can I help you with anything else? Thank you very much.

[InSyncWithFoo]

I still can't reproduce. It appears that the import optimizer gets invoked right after the formatter when nothing is selected (hence the empty lines at the top), but it doesn't when something is selected. I made sure to copied every last setting, yet I could observe no such behaviour.

To be quite frank, I don't know what is going on and I have no idea what the cause might be. Sorry to say, but you probably will have to live with it for now.

[igallart]

Thank you very much for your time. It's no problem that it works this way. The usual thing is to format the entire file, so the imports will work correctly.

If this issue helps to uncover any hidden errors or improve the plugin in some way, then it has served a purpose.

Thank you.