Misc. build updates

Author: jpenilla

cloud-bukkit/build.gradle.kts

@@ -9,6 +9,7 @@ dependencies {
     compileOnly(libs.bukkit)
     compileOnly(libs.commodore)
     testImplementation(libs.bukkit)
+    testCompileOnly(libs.brigadier)
     javadocLinks(libs.paperApi) {
         isTransitive = false
     }

cloud-bukkit/src/main/java/org/incendo/cloud/bukkit/parser/selector/SelectorUtils.java

@@ -138,15 +138,15 @@ public Object apply(
     private abstract static class SelectorParser<C, T> implements ArgumentParser.FutureArgumentParser<C, T>, SelectorMapper<T>,
             SuggestionProvider<C> {
 
-        protected static final Supplier<Object> NO_PLAYERS_EXCEPTION_TYPE =
+        static final Supplier<Object> NO_PLAYERS_EXCEPTION_TYPE =
                 Suppliers.memoize(() -> findExceptionType("argument.entity.notfound.player"));
-        protected static final Supplier<Object> NO_ENTITIES_EXCEPTION_TYPE =
+        static final Supplier<Object> NO_ENTITIES_EXCEPTION_TYPE =
                 Suppliers.memoize(() -> findExceptionType("argument.entity.notfound.entity"));
 
         private final @Nullable ArgumentParser<C, T> modernParser;
 
         // Hide brigadier references in inner class
-        protected static final class Thrower {
+        static final class Thrower {
 
             private final Object type;
 
@@ -159,14 +159,14 @@ void throwIt() {
             }
         }
 
-        protected SelectorParser(
+        SelectorParser(
                 final boolean single,
                 final boolean playersOnly
         ) {
             this.modernParser = createModernParser(single, playersOnly, this);
         }
 
-        protected CompletableFuture<ArgumentParseResult<T>> legacyParse(
+        CompletableFuture<ArgumentParseResult<T>> legacyParse(
                 final CommandContext<C> commandContext,
                 final CommandInput commandInput
         ) {
@@ -176,7 +176,7 @@ protected CompletableFuture<ArgumentParseResult<T>> legacyParse(
             ));
         }
 
-        protected @NonNull Iterable<@NonNull Suggestion> legacySuggestions(
+        @NonNull Iterable<@NonNull Suggestion> legacySuggestions(
                 final CommandContext<C> commandContext,
                 final CommandInput input
         ) {

cloud-bukkit/src/test/java/org/incendo/cloud/bukkit/parser/EnchantmentArgumentTest.java

@@ -66,6 +66,7 @@ static void setupEnchantments() throws Exception {
                 try {
                     Enchantment.registerEnchantment(mockEnchantment);
                 } catch (final Exception ignored) {
+                    // ignore
                 }
             }
         }

examples/example-bukkit/build.gradle.kts

@@ -12,6 +12,7 @@ dependencies {
     implementation(libs.cloud.annotations)
     implementation(project(":cloud-minecraft-extras"))
     implementation(projects.cloudPaperSignedArguments)
+    compileOnly(libs.brigadier)
     /* Extras */
     implementation(libs.adventurePlatformBukkit)
     implementation(libs.minimessage)

examples/example-bukkit/src/main/java/org/incendo/cloud/examples/bukkit/annotations/feature/BuilderModifierExample.java

@@ -70,10 +70,10 @@ public GameModePredicate(final @NonNull GameMode requiredGameMode) {
 
         @Override
         public boolean test(final @NonNull CommandSender commandSender) {
-            if (!(commandSender instanceof Player)) {
+            if (!(commandSender instanceof Player p)) {
                 return true;
             }
-            return ((Player) commandSender).getGameMode() == this.requiredGameMode;
+            return p.getGameMode() == this.requiredGameMode;
         }
     }
 

examples/example-bukkit/src/main/java/org/incendo/cloud/examples/bukkit/feature/ProcessorExample.java

@@ -82,14 +82,13 @@ public void accept(final @NonNull CommandPostprocessingContext<CommandSender> co
                 return;
             }
             final CommandSender sender = context.commandContext().sender();
-            if (!(sender instanceof Player)) {
+            if (!(sender instanceof Player p)) {
                 return;
             }
-            final Player player = (Player) sender;
-            if (player.getInventory().getBoots() != null) {
+            if (p.getInventory().getBoots() != null) {
                 return;
             }
-            player.sendMessage("You need to wear boots to execute this command!");
+            p.sendMessage("You need to wear boots to execute this command!");
             ConsumerService.interrupt();
         }
     }

gradle/libs.versions.toml

@@ -1,10 +1,10 @@
 [versions]
 # build logic
-cloud-build-logic = "0.0.17"
+cloud-build-logic = "0.0.19"
 checkstyle = "10.12.5"
 stylecheck = "0.2.1"
-ktlint = "0.50.0"
-errorprone = "2.31.0"
+ktlint = "1.8.0"
+errorprone = "2.49.0"
 run-task = "3.0.2"
 
 cloudCore = "2.0.0"
@@ -72,7 +72,7 @@ cloud-buildLogic-rootProject-spotless = { id = "org.incendo.cloud-build-logic.sp
 run-paper = { id = "xyz.jpenilla.run-paper", version.ref = "run-task" }
 run-velocity = { id = "xyz.jpenilla.run-velocity", version.ref = "run-task" }
 run-waterfall = { id = "xyz.jpenilla.run-waterfall", version.ref = "run-task" }
-shadow = { id = "com.gradleup.shadow", version = "9.3.0" }
+shadow = { id = "com.gradleup.shadow", version = "9.4.1" }
 
 [bundles]
 immutables = ["immutables", "immutablesAnnotate"]