Commit 0ca0374
authored
chore: prune Stainless-era CI cruft and vestigial release-doctor (#1364)
The Stainless templates left behind a bunch of CI scaffolding that's
no longer doing anything in this repo:
ci.yml
- `on.push.branches` filter listed Stainless-internal codegen branches
(`integrated/**`, `stl-preview-*`, `codegen/**`, `codegen/stl/**`)
that never land here. Replaced with `branches: [main]` so push runs
fire only on merge.
- `on.pull_request.branches-ignore` filtered the same Stainless
preview branches. Dropped — same reasoning.
- Job-level `if:` guards (`github.event_name == 'push' ||
github.event.pull_request.head.repo.fork` etc.) existed to
deduplicate the duplicate runs you get when both push + pull_request
fire for a same-repo PR. Under the new `on:` shape (push only on
main, pull_request unfiltered) each commit triggers exactly one run,
so the dedup is unnecessary.
- `runs-on` toggled to `depot-ubuntu-24.04` when running under
`stainless-sdks/increase-typescript`. We never run there. Simplified
to `ubuntu-latest`.
- `'codegen metadata'` head-commit guard skipped CI for Stainless's
codegen housekeeping commits. We don't push those.
- The build job's OIDC token + `upload-artifact.sh` step pushed build
tarballs to `pkg.stainless.com/s` for Stainless's preview UI. Dead
endpoint for us. Dropped along with the `id-token: write`
permission it required.
release-doctor.yml + bin/check-release-environment
- The script was a literal no-op (`errors=()` array, never populated,
always prints "ready"). It exists in templates as a pre-flight
check for repos with publish secrets (PYPI_TOKEN etc.); this repo
uses OIDC trusted publishing on npm so there's no token to check.
- Even with checks populated, the only failure mode it catches that
the publish workflow doesn't is "secret literally not set" — which
recovers in 30s by setting the secret and re-running publish.
Without branch-protection enforcement (which we don't have), it's
a soft warning, not a gate. Drop it entirely.1 parent 4786c2e commit 0ca0374
3 files changed
Lines changed: 4 additions & 75 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
| 4 | + | |
12 | 5 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | 6 | | |
17 | 7 | | |
18 | 8 | | |
19 | 9 | | |
20 | 10 | | |
21 | | - | |
22 | | - | |
| 11 | + | |
23 | 12 | | |
24 | 13 | | |
25 | 14 | | |
| |||
37 | 26 | | |
38 | 27 | | |
39 | 28 | | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
| 29 | + | |
45 | 30 | | |
46 | 31 | | |
47 | 32 | | |
| |||
56 | 41 | | |
57 | 42 | | |
58 | 43 | | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | 44 | | |
78 | 45 | | |
79 | 46 | | |
80 | | - | |
81 | | - | |
| 47 | + | |
82 | 48 | | |
83 | 49 | | |
84 | 50 | | |
| |||
This file was deleted.
This file was deleted.
0 commit comments