Don't capture self in TableIter<'a, ...>::iter()#294
Open
dubrowgn wants to merge 1 commit intoIndra-db:mainfrom
Open
Don't capture self in TableIter<'a, ...>::iter()#294dubrowgn wants to merge 1 commit intoIndra-db:mainfrom
TableIter<'a, ...>::iter()#294dubrowgn wants to merge 1 commit intoIndra-db:mainfrom
Conversation
Due to the changes to capture logic in rust 2024 when returning `impl TYPE`, the result of `TableIter::iter()` currently captures an immutable reference to `&self`. Thus, one cannot mutably use a `TableIter` while the results of `TableIter::iter()` are being held. Use precise capturing on `TableIter::iter()` to allow the mutable use of `TableIter` while the result of `TableIter::iter()` is being held. See: https://blog.rust-lang.org/2024/09/05/impl-trait-capture-rules
dubrowgn
force-pushed
the
pr/table-iter-static
branch
from
5ef8386 to
b97658a
Compare
Author
|
Initially, this used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the changes to capture logic in rust 2024 when returning
impl TYPE, the result ofTableIter::iter()currently captures an immutable reference to&self. Thus, one cannot mutably use aTableIterwhile the results ofTableIter::iter()are being held.Use precise capturing on
TableIter::iter()to allow the mutable use ofTableIterwhile the result ofTableIter::iter()is being held.See: https://blog.rust-lang.org/2024/09/05/impl-trait-capture-rules