Skip to content

Commit f446418

Browse files
author
InduSridhar
committed
Make node_image_version a settable __init__ param for agent pool models
Per reviewer feedback (FumingZhang), in addition to removing readonly from _validation, the __init__ methods need to accept node_image_version as a parameter and assign it instead of hardcoding None. Without this, the serializer still cannot pass the value through during rollback. Changes for AgentPool, ManagedClusterAgentPoolProfileProperties, and ManagedClusterAgentPoolProfile (matching Azure#9742 pattern). MachineProperties and Snapshot are unchanged (genuinely read-only).
1 parent 745641d commit f446418

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

  • src/aks-preview/azext_aks_preview/vendored_sdks/azure_mgmt_preview_aks/models

src/aks-preview/azext_aks_preview/vendored_sdks/azure_mgmt_preview_aks/models/_models_py3.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -661,6 +661,7 @@ def __init__( # pylint: disable=too-many-locals
661661
type_properties_type: Optional[Union[str, "_models.AgentPoolType"]] = None,
662662
mode: Optional[Union[str, "_models.AgentPoolMode"]] = None,
663663
orchestrator_version: Optional[str] = None,
664+
node_image_version: Optional[str] = None,
664665
upgrade_strategy: Optional[Union[str, "_models.UpgradeStrategy"]] = None,
665666
enable_os_disk_full_caching: Optional[bool] = None,
666667
upgrade_settings: Optional["_models.AgentPoolUpgradeSettings"] = None,
@@ -943,7 +944,7 @@ def __init__( # pylint: disable=too-many-locals
943944
self.mode = mode
944945
self.orchestrator_version = orchestrator_version
945946
self.current_orchestrator_version: Optional[str] = None
946-
self.node_image_version: Optional[str] = None
947+
self.node_image_version = node_image_version
947948
self.upgrade_strategy = upgrade_strategy
948949
self.enable_os_disk_full_caching = enable_os_disk_full_caching
949950
self.upgrade_settings = upgrade_settings
@@ -6605,6 +6606,7 @@ def __init__( # pylint: disable=too-many-locals
66056606
type: Optional[Union[str, "_models.AgentPoolType"]] = None,
66066607
mode: Optional[Union[str, "_models.AgentPoolMode"]] = None,
66076608
orchestrator_version: Optional[str] = None,
6609+
node_image_version: Optional[str] = None,
66086610
upgrade_strategy: Optional[Union[str, "_models.UpgradeStrategy"]] = None,
66096611
enable_os_disk_full_caching: Optional[bool] = None,
66106612
upgrade_settings: Optional["_models.AgentPoolUpgradeSettings"] = None,
@@ -6887,7 +6889,7 @@ def __init__( # pylint: disable=too-many-locals
68876889
self.mode = mode
68886890
self.orchestrator_version = orchestrator_version
68896891
self.current_orchestrator_version: Optional[str] = None
6890-
self.node_image_version: Optional[str] = None
6892+
self.node_image_version = node_image_version
68916893
self.upgrade_strategy = upgrade_strategy
68926894
self.enable_os_disk_full_caching = enable_os_disk_full_caching
68936895
self.upgrade_settings = upgrade_settings
@@ -7263,6 +7265,7 @@ def __init__( # pylint: disable=too-many-locals
72637265
type: Optional[Union[str, "_models.AgentPoolType"]] = None,
72647266
mode: Optional[Union[str, "_models.AgentPoolMode"]] = None,
72657267
orchestrator_version: Optional[str] = None,
7268+
node_image_version: Optional[str] = None,
72667269
upgrade_strategy: Optional[Union[str, "_models.UpgradeStrategy"]] = None,
72677270
enable_os_disk_full_caching: Optional[bool] = None,
72687271
upgrade_settings: Optional["_models.AgentPoolUpgradeSettings"] = None,
@@ -7546,6 +7549,7 @@ def __init__( # pylint: disable=too-many-locals
75467549
type=type,
75477550
mode=mode,
75487551
orchestrator_version=orchestrator_version,
7552+
node_image_version=node_image_version,
75497553
upgrade_strategy=upgrade_strategy,
75507554
enable_os_disk_full_caching=enable_os_disk_full_caching,
75517555
upgrade_settings=upgrade_settings,

0 commit comments

Comments
 (0)