Fix Ourmoji scheduled run activation

Author: OpenClaw (block)

app/server/plugins/ourmoji-scheduler.ts

@@ -4,30 +4,82 @@
  * On startup runs one catch-up sweep, then sweeps every 15 minutes.
  *
  * Sweep algorithm:
- *   1. Load all `active` runs.
- *   2. For each, compute today's "night date" in the run's earliest
+ *   1. Reconcile run lifecycle state (`scheduled -> active`,
+ *      `active|paused -> completed`) based on each run's local date.
+ *   2. Load all `active` runs.
+ *   3. For each, compute today's "night date" in the run's earliest
  *      participant timezone, and the 21:00 anchor in UTC.
- *   3. If the anchor has passed (or we're catching up after downtime),
+ *   4. If the anchor has passed (or we're catching up after downtime),
  *      generate assignments for tonight via the assignments service —
  *      this is idempotent at the DB level.
- *   4. Dispatch notifications for each freshly-inserted assignment.
+ *   5. Dispatch notifications for each freshly-inserted assignment.
  *
  * Failures are logged but never thrown — the timer keeps ticking.
  */
 
 import { ourmojiSchedulerLogger as logger } from "~/server/services/ourmoji/logger";
-import { listExperimentRunsByStatus, getParticipantsForRun } from "~/server/services/ourmoji/repository";
+import {
+  listExperimentRunsByStatus,
+  getParticipantsForRun,
+  updateExperimentRunStatus,
+} from "~/server/services/ourmoji/repository";
 import { generateAssignmentsForNight } from "~/server/services/ourmoji/assignments";
 import { dispatchAssignmentNotification } from "~/server/services/ourmoji/notifications";
 import {
   computeNextAnchorUtc,
+  localDateInTimezone,
   nightDateForAnchor,
 } from "~/server/services/ourmoji/schedule";
 
 const SWEEP_INTERVAL_MS = 15 * 60 * 1000; // 15 minutes
 
+async function reconcileRunStatuses(now: Date): Promise<void> {
+  const scheduledRuns = await listExperimentRunsByStatus(["scheduled"]);
+  for (const run of scheduledRuns) {
+    const localToday = localDateInTimezone(
+      now,
+      run.earliestParticipantTimezone || "UTC",
+    );
+
+    if (run.endDate < localToday) {
+      await updateExperimentRunStatus(run.id, "completed");
+      logger.info("Completed expired scheduled run", {
+        runId: run.id,
+        localToday,
+      });
+      continue;
+    }
+
+    if (run.startDate <= localToday) {
+      await updateExperimentRunStatus(run.id, "active");
+      logger.info("Activated scheduled run", {
+        runId: run.id,
+        localToday,
+      });
+    }
+  }
+
+  const liveRuns = await listExperimentRunsByStatus(["active", "paused"]);
+  for (const run of liveRuns) {
+    const localToday = localDateInTimezone(
+      now,
+      run.earliestParticipantTimezone || "UTC",
+    );
+    if (run.endDate < localToday) {
+      await updateExperimentRunStatus(run.id, "completed");
+      logger.info("Completed finished run", {
+        runId: run.id,
+        previousStatus: run.status,
+        localToday,
+      });
+    }
+  }
+}
+
 async function sweep(): Promise<void> {
   const now = new Date();
+  await reconcileRunStatuses(now);
+
   const runs = await listExperimentRunsByStatus(["active"]);
   if (runs.length === 0) {
     logger.debug("Sweep tick — no active runs");

app/server/services/ourmoji/schedule.test.ts

@@ -9,6 +9,7 @@
 import { describe, expect, it } from "vitest";
 import {
   computeNextAnchorUtc,
+  localDateInTimezone,
   nightDateForAnchor,
   nightIndexForRun,
 } from "./schedule";
@@ -26,7 +27,7 @@ describe("nightIndexForRun", () => {
   });
 });
 
-describe("nightDateForAnchor", () => {
+describe("localDateInTimezone / nightDateForAnchor", () => {
   it("returns the local YYYY-MM-DD for an anchor instant", () => {
     // 21:00 UTC on 2026-04-10 — same calendar day in UTC
     const anchor = new Date("2026-04-10T21:00:00Z");
@@ -37,6 +38,12 @@ describe("nightDateForAnchor", () => {
     const anchor = new Date("2026-04-11T04:00:00Z");
     expect(nightDateForAnchor(anchor, "America/Los_Angeles")).toBe("2026-04-10");
   });
+  it("returns today's local date for arbitrary instants", () => {
+    const instant = new Date("2026-04-29T22:30:00Z");
+    expect(localDateInTimezone(instant, "UTC")).toBe("2026-04-29");
+    expect(localDateInTimezone(instant, "Europe/London")).toBe("2026-04-29");
+    expect(localDateInTimezone(instant, "America/Los_Angeles")).toBe("2026-04-29");
+  });
 });
 
 describe("computeNextAnchorUtc", () => {

app/server/services/ourmoji/schedule.ts

@@ -58,7 +58,17 @@ export function nightDateForAnchor(
   anchorUtc: Date,
   timezone: string,
 ): string {
-  const { year, month, day } = getLocalYMD(anchorUtc, timezone);
+  return localDateInTimezone(anchorUtc, timezone);
+}
+
+/**
+ * Returns the local YYYY-MM-DD for an arbitrary instant in `timezone`.
+ */
+export function localDateInTimezone(
+  instant: Date,
+  timezone: string,
+): string {
+  const { year, month, day } = getLocalYMD(instant, timezone);
   return `${pad4(year)}-${pad2(month)}-${pad2(day)}`;
 }