Skip to content

Commit 23cbe67

Browse files
committed
Eeeven more lint
1 parent a508d5c commit 23cbe67

2 files changed

Lines changed: 12 additions & 24 deletions

File tree

my-app/src/presenters/ListViewPresenter.jsx

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,14 @@ import PrerequisitePresenter from './PrerequisitePresenter.jsx';
77

88
const ListViewPresenter = observer(({ model }) => {
99

10+
const handleFavouriteClick = (course) => {
11+
if (model.favourites.some(fav => fav.code === course.code)) {
12+
model.removeFavourite(course);
13+
} else {
14+
model.addFavourite(course);
15+
}
16+
};
17+
1018
const [isPopupOpen, setIsPopupOpen] = useState(false);
1119
const [selectedCourse, setSelectedCourse] = useState(null);
1220
const preP = <PrerequisitePresenter model={model} selectedCourse={selectedCourse}/>
@@ -19,14 +27,6 @@ const ListViewPresenter = observer(({ model }) => {
1927
model.removeFavourite(course);
2028
}
2129

22-
function handleFavouriteClick(course){
23-
if (props.favouriteCourses.some(fav => fav.code === course.code)) {
24-
props.removeFavourite(course);
25-
} else {
26-
props.addFavourite(course);
27-
}
28-
};
29-
3030
return <ListView
3131
courses={model.courses}
3232
searchResults={model.currentSearch}
@@ -37,6 +37,7 @@ const ListViewPresenter = observer(({ model }) => {
3737
setIsPopupOpen={setIsPopupOpen}
3838
setSelectedCourse={setSelectedCourse}
3939
popUp={popup}
40+
handleFavouriteClick={handleFavouriteClick}
4041

4142
/>;
4243
});

my-app/src/views/ListView.jsx

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,12 @@ function ListView(props) {
1111
{ ...prevState, [courseCode]: !prevState[courseCode] }
1212
));
1313
};
14-
1514

1615
return (
1716
<div className="relative bg-white text-black p-2 flex flex-col gap-5 h-full overflow-auto">
1817
{coursesToDisplay.length > 0 ? (
1918
coursesToDisplay.map((course) => (
2019
<div
21-
onClick={() => {
22-
console.log('Clicked:', course); // check browser console
23-
props.setSelectedCourse(course);
24-
props.setIsPopupOpen(true);
25-
}}
2620
key={course.code}
2721
className="p-5 hover:bg-blue-100 flex items-center border border-b-black border-solid w-full rounded-lg cursor-pointer"
2822
>
@@ -40,10 +34,7 @@ function ListView(props) {
4034
{course.description.length > 150 && (
4135
<span
4236
className="text-blue-500 cursor-pointer"
43-
onClick={(e) => {
44-
e.stopPropagation(); // Prevent the event from bubbling up.
45-
toggleReadMore(course.code);
46-
}}
37+
onClick={() => toggleReadMore(course.code)}
4738
>
4839
{readMoreState[course.code]
4940
?
@@ -55,10 +46,7 @@ function ListView(props) {
5546
<div>
5647
<button
5748
className="text-yellow-500 cursor-pointer"
58-
onClick={(e) => {
59-
e.stopPropagation(); // Prevent the event from bubbling up.
60-
handleFavouriteClick(course);
61-
}}
49+
onClick={() => props.handleFavouriteClick(course)}
6250
>
6351
{props.favouriteCourses.some(fav => fav.code === course.code)
6452
?
@@ -78,9 +66,8 @@ function ListView(props) {
7866
color="#000061"
7967
/>
8068
)}
81-
{props.popUp}
8269
</div>
8370
);
8471
}
8572

86-
export default ListView;
73+
export default ListView;

0 commit comments

Comments
 (0)