Skip to content

Commit 3a62c17

Browse files
committed
small fixes
1 parent 1950a4e commit 3a62c17

File tree

2 files changed

+8
-26
lines changed

2 files changed

+8
-26
lines changed

my-app/src/presenters/ListViewPresenter.jsx

Lines changed: 7 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,12 @@ import CoursePagePopup from '../views/Components/CoursePagePopup.jsx';
66
import PrerequisitePresenter from './PrerequisitePresenter.jsx';
77

88
const ListViewPresenter = observer(({ model }) => {
9-
10-
<<<<<<< HEAD
11-
12-
13-
const [isPopupOpen, setIsPopupOpen] = useState(false);
14-
const [selectedCourse, setSelectedCourse] = useState(null);
15-
const preP = <PrerequisitePresenter model={model} selectedCourse={selectedCourse} />
16-
=======
9+
const addFavourite = (course) => {
10+
model.addFavourite(course);
11+
}
12+
const removeFavourite = (course) => {
13+
model.removeFavourite(course);
14+
}
1715
const handleFavouriteClick = (course) => {
1816
if (model.favourites.some(fav => fav.code === course.code)) {
1917
model.removeFavourite(course);
@@ -24,16 +22,8 @@ const ListViewPresenter = observer(({ model }) => {
2422

2523
const [isPopupOpen, setIsPopupOpen] = useState(false);
2624
const [selectedCourse, setSelectedCourse] = useState(null);
27-
const preP = <PrerequisitePresenter model={model} selectedCourse={selectedCourse}/>
28-
const popup = <CoursePagePopup isOpen={isPopupOpen} onClose={() => setIsPopupOpen(false)} course={selectedCourse} handleFavouriteClick={handleFavouriteClick} prerequisiteTree={preP}/>
25+
const preP = <PrerequisitePresenter model={model} selectedCourse={selectedCourse} />
2926

30-
>>>>>>> a6593340b954b95fa693730a4ba199b2268736ff
31-
const addFavourite = (course) => {
32-
model.addFavourite(course);
33-
}
34-
const removeFavourite = (course) => {
35-
model.removeFavourite(course);
36-
}
3727
const popup = <CoursePagePopup
3828
favouriteCourses={model.favourites}
3929
addFavourite={addFavourite}

my-app/src/views/Components/CoursePagePopup.jsx

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import React, { useEffect, useRef } from 'react'
2-
import React, { useEffect, useRef } from 'react'
32

43
function CoursePagePopup({ favouriteCourses, addFavourite,
54
removeFavourite, isOpen, onClose, course, prerequisiteTree }) {
@@ -42,7 +41,6 @@ function CoursePagePopup({ favouriteCourses, addFavourite,
4241
onClick={onClose}
4342
>
4443
<div
45-
className="bg-indigo-300/75 backdrop-blur-lg h-full w-3/4 flex flex-col overflow-auto"
4644
className="bg-indigo-300/75 backdrop-blur-lg h-full w-3/4 flex flex-col overflow-auto"
4745
onClick={(e) => e.stopPropagation()}
4846
>
@@ -57,14 +55,13 @@ function CoursePagePopup({ favouriteCourses, addFavourite,
5755
</span>
5856
</h2>
5957
<div className="my-6 h-1.5 w-full bg-violet-500"></div>
60-
<div className="my-6 h-1.5 w-full bg-violet-500"></div>
6158
</div>
6259
<div>
6360
<button
6461
className="text-yellow-500 bg-yellow-400 cursor-pointer"
6562
onClick={(e) => {
6663
e.stopPropagation(); // prevent popup from opening
67-
PaymentResponse.handleFavouriteClick(course.code);
64+
handleFavouriteClick(course.code);
6865
}}
6966
>
7067
{favouriteCourses.includes(course.code)
@@ -75,12 +72,9 @@ function CoursePagePopup({ favouriteCourses, addFavourite,
7572

7673
{/* Description Section */}
7774
<div>
78-
<h3 className="text-2xl font-bold text-[#2e2e4f] mb-0.5">Course Description</h3>
79-
<div className="mb-3 h-0.5 w-full bg-violet-500"></div>
8075
<h3 className="text-2xl font-bold text-[#2e2e4f] mb-0.5">Course Description</h3>
8176
<div className="mb-3 h-0.5 w-full bg-violet-500"></div>
8277
<div
83-
className="text-lg leading-8 text-[#2e2e4f] font-semibold tracking-wide prose prose-slate max-w-full"
8478
className="text-lg leading-8 text-[#2e2e4f] font-semibold tracking-wide prose prose-slate max-w-full"
8579
dangerouslySetInnerHTML={{ __html: course.description }}
8680
/>
@@ -105,8 +99,6 @@ function CoursePagePopup({ favouriteCourses, addFavourite,
10599
</div>
106100
{/* Reviews Section */}
107101
<div>
108-
<h3 className="text-2xl font-semibold text-[#2e2e4f] mb-0.5">Reviews</h3>
109-
<div className="mb-4 h-0.5 w-full bg-violet-500"></div>
110102
<h3 className="text-2xl font-semibold text-[#2e2e4f] mb-0.5">Reviews</h3>
111103
<div className="mb-4 h-0.5 w-full bg-violet-500"></div>
112104
<p className="text-lg text-slate-700 leading-7">Here would be some reviews of the course...</p>

0 commit comments

Comments
 (0)