fixes

Author: jkluge

my-app/src/presenters/PrerequisitePresenter.jsx

@@ -2,7 +2,7 @@ import { observer } from "mobx-react-lite";
 import PrerequisiteTreeView from "../views/PrerequisiteTreeView";
 
 import dagre from '@dagrejs/dagre';
-import { useCallback, useMemo } from "react";
+import { useCallback } from "react";
 
 import {
     Background,
@@ -17,10 +17,6 @@ import { model } from "../model";
 
 
 export const PrerequisitePresenter = observer((props) => {
-    const nodes = useMemo(() => {
-        if (!props.selectedCourse?.prerequisites) return [];
-        return createNodes(props.selectedCourse.prerequisites);
-    }, [props.selectedCourse?.prerequisites]);
 
     let uniqueCounter = 0;
     let textCounter = 0;
@@ -219,6 +215,11 @@ export const PrerequisitePresenter = observer((props) => {
             type: node_type,
             data: { label: name },
             style: { 
+                //padding: 0,
+                //maxWidth: "100px",
+                //display: 'inline-block',
+                //justifyContent: 'center',
+                //alignItems: 'center',
                 zIndex: 0 
             },
             position,
@@ -483,9 +484,7 @@ export const PrerequisitePresenter = observer((props) => {
                 let copy = JSON.parse(JSON.stringify(props.selectedCourse.prerequisites));
                 let courses_taken = [];
                 if (localStorage.getItem("completedCourses") != null) {
-                    for (let obj of localStorage.getItem("completedCourses")) {
-                        courses_taken.push(obj?.id);    
-                    }
+                    courses_taken = localStorage.getItem("completedCourses");
                 }
                 code_to_name = model.getCourseNames(courses_taken);
 

my-app/src/presenters/ReviewPresenter.jsx

@@ -41,29 +41,33 @@ export const ReviewPresenter = observer(({ model, course }) => {
             setErrorMessage("You need to be logged in to post a comment - Posting anonymously is possible.");
             return;
         }
-        if (formData.text.trim()) {
-            const review = {
-                userName: postAnonymous ? "Anonymous" : model.user?.displayName,
-                uid: model?.user?.uid,
-                timestamp: Date.now(),
-                ...formData,
 
-            };
-            if(!await model.addReview(course.code, review)){    
-                setErrorMessage("Something went wrong when posting. Are you logged in?")
-                return;
-            }
-            const updatedReviews = await model.getReviews(course.code);
-            setReviews(updatedReviews);
-            setFormData({
-                text: "",
-                overallRating: 0,
-                difficultyRating: 0,
-                professorName: "",
-                grade: "",
-                recommended: false,
-            });
+        if (!formData.text.trim() && formData.overallRating === 0) {
+            setErrorMessage("Please provide either a review text or an overall rating.");
+            return;
+        }
+
+        const review = {
+            userName: postAnonymous ? "Anonymous" : model.user?.displayName,
+            uid: model?.user?.uid,
+            timestamp: Date.now(),
+            ...formData,
+        };
+        
+        if(!await model.addReview(course.code, review)){    
+            setErrorMessage("Something went wrong when posting. Are you logged in?")
+            return;
         }
+        const updatedReviews = await model.getReviews(course.code);
+        setReviews(updatedReviews);
+        setFormData({
+            text: "",
+            overallRating: 0,
+            difficultyRating: 0,
+            professorName: "",
+            grade: "",
+            recommended: false,
+        });
     };
 
 

my-app/src/views/ListView.jsx

@@ -274,7 +274,7 @@ function ListView(props) {
                 </div>
             )}
             {props.popup}
-            {!isLoading && props.targetScroll > 1000 && (
+            {!isLoading && !props.isPopupOpen && props.targetScroll > 1000 && (
                 <button
                     onClick={() => props.setTargetScroll(0)}
                 className="fixed bottom-6 right-6 z-50 bg-[#000061] text-white p-3 rounded-full shadow-lg hover:bg-[#1a1a80] transition-all"