Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces enhancements to the searchbar functionality and integrates a favourites feature across views and the model.
- Updated SearchbarView to include a favourites toggle, new project logo, and improved sign in/out UI.
- Modified ListView to support a "read more" toggle for course descriptions and favourites actions.
- Updated presenters and model to manage search results and favourites.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| my-app/src/views/SearchbarView.jsx | Updated UI elements, added favourites toggle, and refactored search logic. |
| my-app/src/views/ListView.jsx | Added "read more" functionality and integrated favourites actions. |
| my-app/src/views/Components/FavouriteDropdown.jsx | Introduced a new dropdown component to display favourite courses. |
| my-app/src/presenters/SearchbarPresenter.jsx | Passed new searchCourses and favourites-related props to SearchbarView. |
| my-app/src/presenters/ListViewPresenter.jsx | Updated prop handling for courses, search results, and favourites. |
| my-app/src/model.js | Revised currentSearch type and added methods to manage favourites. |
LSKpr
approved these changes
Apr 3, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.