Invalidate ninetoothed.build cache when inputs change#151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_load_cachedinninetoothed.buildpreviously returned the cached.sowhenever it existed on disk, regardless of whether the source code, configs, or library internals had changed since it was produced. That let stale artifacts silently survive acrosspremake,configs, orninetoothedupdates — e.g. twotests/test_aot.py::test_conv2dcases were failing with_KernelLaunchErrorbecause cached.sofiles from before thetest_aot.pyargument list grew were still being loaded.Changes
_compute_fingerprint(premake, configs, meta_parameters, caller)that SHA-256s thepremakesource (withfunctools.partialargs and keywords folded in),configs,meta_parameters,caller, and the contents ofbuild.pyandaot.py.<kernel_name>.fingerprintalongside the other build artifacts._load_cachedreturnsNonewhen the fingerprint file is missing or its contents do not match.configs(andmeta_parameterswhen set) to tuples up front so pre-iterating them for the fingerprint does not exhaust generators.Testing
Testing
pytestoutput: