Promote scalar float32 to float64 in AOT signature#153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_build_variantnow lifts a scalarfp32argument tofp64in theTriton AOT signature. Without this, a scalar
Tensor(0, dtype=ninetoothed.float32)silently arrives as
0.0finside the kernel on Triton 3.4.0+ —triton.tools.compiledeclares the wrapper parameter as Cdoublebut the cubin still reads 4 bytes as
float, so the low half of the8-byte double (zero for small values like
0.125) gets fed to thekernel.
Triton ABI sweep
Compiled
kernel(scale, out_ptr, n: tl.constexpr)with signature'fp32, *fp32:16, 16'on every tested version:fp32float scaledouble scaleRe-running the sweep with signature
'fp64, ...'givesdouble scaleconsistently, so the wrapper,
args[], and cubin agree on 8 bytesacross 3.1.0 – 3.7.0 (latest). The promotion is therefore harmless on
3.1 – 3.3 (no precision lost since the underlying Python value is
already 64-bit) and fixes the silent corruption on 3.4+.
Testing
pytestoutput: