Add relu operator#9
Merged
Merged
Conversation
voltjia
requested changes
May 7, 2025
Collaborator
voltjia
left a comment
There was a problem hiding this comment.
Please use Markdown syntax to denote a word or phrase as code in the commit messages:
- Add
reluoperator - Remove the asterisk in the declaration of function
reluinsrc/ntops/torch.py - Add
inplaceparameter forrelu
In src/ntops/kernels/relu.py, we don't actually need a replace parameter, because we can implement the inplace logic in src/ntops/torch.py:
def relu(input, inplace=False):
if inplace:
output = input
else:
output = torch.empty_like(input)
kernel = ntops.kernels.relu.make(input.ndim)
kernel(input, output)
return outputPlease change src/ntops/torch.py and tests/test_relu.py accordingly.
In addition, we use Ruff as our Python linter and code formatter. Please run the following before each commit:
ruff format
ruff check
voltjia
requested changes
May 8, 2025
Collaborator
voltjia
left a comment
There was a problem hiding this comment.
Nice work! There's just one last minor issue: In tests/test_relu.py, is replace a typo? If so, please change it to inplace.
…s/test_relu.py`
voltjia
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytestoutput: