66 - main
77 - master
88 tags :
9- - ' v*'
9+ - ' v*' # release tags in format of e.g: 'v25.12.00'
1010
1111 pull_request :
1212 types : [opened, synchronize, reopened, labeled]
6868 repository : InfinyTech3D/MeshRefinement
6969 token : ${{ secrets.MESH_REFINEMENT_DEPLOY_KEY }}
7070
71- # ############## Build and install MeshRefinement ##############
71+ # ############## Build and install MeshRefinement only if enabled ##############
7272 - name : Build and install MeshRefinement
7373 if : matrix.with_mesh_refinement == 'ON'
7474 shell : bash
8484 -DCMAKE_INSTALL_PREFIX=%GITHUB_WORKSPACE%/deps/MeshRefinement/install \
8585 .. \
8686 && ninja install"
87-
87+ # Temp hack
8888 cp deps/MeshRefinement/install/bin/MeshRefinement.dll "$WORKSPACE_BUILD_PATH/"
8989
9090 else
@@ -103,9 +103,9 @@ jobs:
103103 - name : Checkout current source code
104104 uses : actions/checkout@v4
105105 with :
106+ # ############### Build and install current plugin ##############
106107 path : ${{ env.WORKSPACE_SRC_PATH }}
107108
108- # ############### Build and install plugin ##############
109109 - name : Build and install
110110 shell : bash
111111 run : |
@@ -138,6 +138,10 @@ jobs:
138138 # ################## Artifact naming ##############
139139 - name : Sanitize artifact name
140140 id : sanitize
141+ # This step removes special characters from the artifact name to ensure compatibility with upload-artifact
142+ # Characters removed: " : < > | * ? \r \n \ /
143+ # Spaces are replaced with underscores
144+ # This sanitization prevents errors in artifact creation and retrieval
141145 shell : pwsh
142146 run : |
143147 if ("${{ matrix.with_mesh_refinement }}" -eq "ON") {
@@ -146,18 +150,24 @@ jobs:
146150 else {
147151 $dependency = "standalone"
148152 }
149-
150- $originalName = "InfinyToolkit_${dependency}_${{ steps.sofa.outputs.run_branch }}_SOFA -${{ steps.sofa.outputs.sofa_version }}_${{ runner.os }}"
153+
154+ $originalName = "InfinyToolkit_${dependency}_${{ steps.sofa.outputs.run_branch }}_for-SOFA -${{ steps.sofa.outputs.sofa_version }}_${{ runner.os }}"
151155 $artifact_name = $originalName -replace '[":;<>|*?\r\n\\/]', '' -replace ' ', '_'
152156 echo "artifact_name=$artifact_name" >> $env:GITHUB_OUTPUT
153-
154- # ################## Upload artifact ##############
157+
158+ # ################## Create and upload artifact ##############
155159 - name : Create artifact
160+ id : create-artifact
156161 uses : actions/upload-artifact@v4.4.0
157162 with :
158163 name : ${{ steps.sanitize.outputs.artifact_name }}
159164 path : ${{ env.WORKSPACE_INSTALL_PATH }}
160165
166+ - name : Install artifact
167+ uses : actions/download-artifact@v4.1.7
168+ with :
169+ name : ${{ steps.sanitize.outputs.artifact_name }}
170+ path : ${{ env.WORKSPACE_ARTIFACT_PATH }}
161171 # ################## Tests ##############
162172 - name : Launch test
163173 uses : sofa-framework/sofa-test-action@v1.0
0 commit comments