Skip to content

feat: updated the rollback to be aligned with our environment and path.#6461

Merged
akhilmhdh merged 4 commits into
mainfrom
SEC-5
May 23, 2026
Merged

feat: updated the rollback to be aligned with our environment and path.#6461
akhilmhdh merged 4 commits into
mainfrom
SEC-5

Conversation

@akhilmhdh
Copy link
Copy Markdown
Member

Context

This PR updates the rollback permission to more aligned with other permission in the dashboard. The rollback permission can now be scoped to an environment and secret path. The old permission rollback was broken for new custom roles as our UI didn't allow to add it and thus replaced it with the commit permission.

The rollbackSnapshot service was removed because it's not used anymore and the router using it was throwing error as deprecated.

Screenshots

Steps to verify the change

  1. Create a project permission with rollback under a environment and path
  2. It should work in scoped environment

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Updated CLAUDE.md files (if needed)
  • Read the contributing guide

@akhilmhdh akhilmhdh requested a review from mathnogueira May 13, 2026 20:15
@akhilmhdh akhilmhdh self-assigned this May 13, 2026
@linear
Copy link
Copy Markdown

linear Bot commented May 13, 2026

SEC-5

@infisical-review-police
Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-infisical-6461-feat-updated-the-rollback-to-be-aligned-with-our-enviro

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

Comment thread backend/src/ee/services/pit/pit-service.ts
Comment thread frontend/src/context/ProjectPermissionContext/types.ts
Comment thread backend/src/services/secret/secret-service.ts
Comment thread backend/src/services/secret/secret-service.ts
@mathnogueira mathnogueira self-requested a review May 21, 2026 13:24
@gitguardian
Copy link
Copy Markdown

gitguardian Bot commented May 22, 2026

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9387833 Triggered Generic Password f377efd backend-go/docker-compose.test.yml View secret
29105343 Triggered Generic High Entropy Secret f377efd backend-go/internal/server/gen/http/secrets/client/encode_decode.go View secret
28944329 Triggered PostHog Project API Key f377efd backend-go/internal/config/config.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@akhilmhdh akhilmhdh merged commit 03bd644 into main May 23, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants