Skip to content

Commit d284a3d

Browse files
authored
fix run duration error (#182)
Signed-off-by: kerthcet <kerthcet@gmail.com>
1 parent 91919db commit d284a3d

13 files changed

Lines changed: 597 additions & 590 deletions

File tree

alphatrion/server/graphql/resolvers.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ def list_runs(
188188
experiment_id=r.experiment_id,
189189
meta=r.meta,
190190
status=GraphQLStatusEnum[Status(r.status).name],
191+
duration=r.duration,
191192
created_at=r.created_at,
192193
)
193194
for r in runs
@@ -205,6 +206,7 @@ def get_run(id: strawberry.ID) -> Run | None:
205206
experiment_id=run.experiment_id,
206207
meta=run.meta,
207208
status=GraphQLStatusEnum[Status(run.status).name],
209+
duration=run.duration,
208210
created_at=run.created_at,
209211
)
210212
return None

alphatrion/server/graphql/types.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@ class Run:
155155
user_id: strawberry.ID
156156
experiment_id: strawberry.ID
157157
meta: JSON | None
158+
duration: float
158159
status: GraphQLStatusEnum
159160
created_at: datetime
160161

dashboard/src/lib/graphql-client.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,7 @@ export const queries = {
206206
userId
207207
experimentId
208208
meta
209+
duration
209210
status
210211
createdAt
211212
}
@@ -220,6 +221,7 @@ export const queries = {
220221
userId
221222
experimentId
222223
meta
224+
duration
223225
status
224226
createdAt
225227
aggregatedTokens {

dashboard/src/pages/experiments/index.tsx

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -270,11 +270,10 @@ export function ExperimentsPage() {
270270
<Table>
271271
<TableHeader>
272272
<TableRow className="hover:bg-transparent border-b">
273-
<TableHead className="h-11 text-xs font-semibold uppercase tracking-wider text-muted-foreground bg-muted/50">UUID</TableHead>
273+
<TableHead className="h-11 text-xs font-semibold uppercase tracking-wider text-muted-foreground bg-muted/50">ID</TableHead>
274274
<TableHead className="h-11 text-xs font-semibold uppercase tracking-wider text-muted-foreground bg-muted/50">Name</TableHead>
275275
<TableHead className="h-11 text-xs font-semibold uppercase tracking-wider text-muted-foreground bg-muted/50">Labels</TableHead>
276276
<TableHead className="h-11 text-xs font-semibold uppercase tracking-wider text-muted-foreground bg-muted/50">Status</TableHead>
277-
<TableHead className="h-11 text-xs font-semibold uppercase tracking-wider text-muted-foreground bg-muted/50 text-right">Duration</TableHead>
278277
<TableHead className="h-11 text-xs font-semibold uppercase tracking-wider text-muted-foreground bg-muted/50 text-right">Created</TableHead>
279278
</TableRow>
280279
</TableHeader>
@@ -320,11 +319,6 @@ export function ExperimentsPage() {
320319
{experiment.status}
321320
</Badge>
322321
</TableCell>
323-
<TableCell className="py-3 text-sm text-foreground tabular-nums text-right">
324-
{experiment.duration > 0
325-
? `${experiment.duration.toFixed(2)}s`
326-
: '-'}
327-
</TableCell>
328322
<TableCell className="py-3 text-sm text-muted-foreground text-right">
329323
{formatDistanceToNow(new Date(experiment.createdAt), {
330324
addSuffix: true,

dashboard/src/pages/runs/[id].tsx

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,16 @@ export function RunDetailPage() {
179179
)}
180180
</dd>
181181
</div>
182+
<div>
183+
<dt className="text-xs font-medium uppercase tracking-wide text-muted-foreground">Duration</dt>
184+
<dd className="mt-1.5 text-foreground font-mono text-sm">
185+
{run.duration !== undefined && run.duration > 0 ? (
186+
`${run.duration.toFixed(2)}s`
187+
) : (
188+
<span className="text-muted-foreground">-</span>
189+
)}
190+
</dd>
191+
</div>
182192
<div>
183193
<dt className="text-xs font-medium uppercase tracking-wide text-muted-foreground">Created</dt>
184194
<dd className="mt-1.5 text-foreground text-sm">

dashboard/src/pages/runs/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ export function RunsPage() {
151151
<Table>
152152
<TableHeader>
153153
<TableRow className="hover:bg-transparent border-b">
154-
<TableHead className="h-11 text-xs font-semibold uppercase tracking-wider text-muted-foreground bg-muted/50">UUID</TableHead>
154+
<TableHead className="h-11 text-xs font-semibold uppercase tracking-wider text-muted-foreground bg-muted/50">ID</TableHead>
155155
<TableHead className="h-11 text-xs font-semibold uppercase tracking-wider text-muted-foreground bg-muted/50">Experiment ID</TableHead>
156156
<TableHead className="h-11 text-xs font-semibold uppercase tracking-wider text-muted-foreground bg-muted/50">Status</TableHead>
157157
<TableHead className="h-11 text-xs font-semibold uppercase tracking-wider text-muted-foreground bg-muted/50 text-right">Created</TableHead>

dashboard/src/types/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ export interface Run {
7272
userId: string;
7373
experimentId: string;
7474
meta: Record<string, unknown> | null;
75+
duration: number;
7576
status: Status;
7677
createdAt: string;
7778
aggregatedTokens: TokenStats;

dashboard/static/assets/index-C4qfalyR.css

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dashboard/static/assets/index-C7uEdDQh.css

Lines changed: 0 additions & 1 deletion
This file was deleted.

dashboard/static/assets/index-CZV_pqRz.js

Lines changed: 0 additions & 578 deletions
This file was deleted.

0 commit comments

Comments
 (0)