Update archived repos#169
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdates ChangesJoin-a-network documentation refresh
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
| # version reported by a public mainnet node and use the matching injective-core release. | ||
| curl -s https://sentry.lcd.injective.network/cosmos/base/tendermint/v1beta1/node_info | jq -r '.application_version.version' | ||
|
|
||
| wget https://github.com/InjectiveFoundation/injective-core/releases/download/v1.20.0-1780128924/linux-amd64.zip |
There was a problem hiding this comment.
Is this the right version?
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
.gitbook/infra/join-a-network.mdx (1)
202-206: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winVersion-check guidance conflicts with hardcoded release URLs
These sections tell operators to verify the live network version, but the actual install command still downloads a fixed tag. After network upgrades, this will guide users into a mismatch unless they manually rewrite the URL.
Suggested doc fix
-# The live testnet currently runs v1.20.0-beta.2. Before installing, verify the -# version reported by a public testnet node and use the matching injective-core release. +# Before installing, verify the version reported by a public testnet node. curl -s https://testnet.sentry.lcd.injective.network/cosmos/base/tendermint/v1beta1/node_info | jq -r '.application_version.version' - -wget https://github.com/InjectiveFoundation/injective-core/releases/download/v1.20.0-beta.2-1779837158/linux-amd64.zip +# Then download the corresponding injective-core release tag (including build suffix) from: +# https://github.com/InjectiveFoundation/injective-core/releases +wget https://github.com/InjectiveFoundation/injective-core/releases/download/<matching-tag>/linux-amd64.zip-# The live mainnet currently runs v1.20.0. Before installing, verify the -# version reported by a public mainnet node and use the matching injective-core release. +# Before installing, verify the version reported by a public mainnet node. curl -s https://sentry.lcd.injective.network/cosmos/base/tendermint/v1beta1/node_info | jq -r '.application_version.version' - -wget https://github.com/InjectiveFoundation/injective-core/releases/download/v1.20.0-1780128924/linux-amd64.zip +# Then download the corresponding injective-core release tag (including build suffix) from: +# https://github.com/InjectiveFoundation/injective-core/releases +wget https://github.com/InjectiveFoundation/injective-core/releases/download/<matching-tag>/linux-amd64.zipAlso applies to: 321-325
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.gitbook/infra/join-a-network.mdx around lines 202 - 206, The documentation in the testnet setup section provides a version verification command via curl but then downloads a hardcoded release URL (v1.20.0-beta.2-1779837158), creating a mismatch that requires manual updates after network upgrades. Update the wget command to either demonstrate how to dynamically substitute the verified version from the curl output into the download URL, or use a variable or placeholder to make it explicit that the hardcoded version must be replaced with the actual version verified from the live testnet node. This applies to both the initial section and the additional location at lines 321-325 to ensure consistency across the documentation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.gitbook/infra/join-a-network.mdx:
- Around line 233-235: Add AWS CLI installation instructions as a prerequisite
step before the aws s3 cp command that downloads the genesis file. Include
installation commands for multiple platforms (such as apt-get install awscli for
Linux distributions and brew install awscli for macOS) to ensure users on fresh
hosts can successfully execute the aws s3 cp command without encountering
command-not-found errors. Place these installation instructions in a new
prerequisite section that appears before the step containing the aws s3 cp
--no-sign-request s3://injective-snapshots/testnet/genesis.json command.
---
Duplicate comments:
In @.gitbook/infra/join-a-network.mdx:
- Around line 202-206: The documentation in the testnet setup section provides a
version verification command via curl but then downloads a hardcoded release URL
(v1.20.0-beta.2-1779837158), creating a mismatch that requires manual updates
after network upgrades. Update the wget command to either demonstrate how to
dynamically substitute the verified version from the curl output into the
download URL, or use a variable or placeholder to make it explicit that the
hardcoded version must be replaced with the actual version verified from the
live testnet node. This applies to both the initial section and the additional
location at lines 321-325 to ensure consistency across the documentation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 174b16f6-1760-47d6-b480-baf1e7c98058
📒 Files selected for processing (1)
.gitbook/infra/join-a-network.mdx
| # Copy the testnet genesis file to the node config directory. | ||
| aws s3 cp --no-sign-request s3://injective-snapshots/testnet/genesis.json . | ||
| mv genesis.json ~/.injectived/config/ |
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify whether AWS CLI prerequisites are documented alongside this guide.
set -euo pipefail
TARGET=".gitbook/infra/join-a-network.mdx"
echo "== AWS command usages =="
rg -n --no-heading '\baws\s+s3\s+cp\b' "$TARGET"
echo
echo "== Nearby prerequisite/install references =="
rg -n --no-heading -C3 'awscli|aws cli|install aws|brew install aws|apt.*aws|yum.*aws|dnf.*aws' .gitbook/infra/join-a-network.mdx .gitbook/infra/**/*.mdx || true
echo
echo "Expected: at least one explicit prerequisite/install instruction for AWS CLI if aws commands are kept."Repository: InjectiveLabs/injective-docs
Length of output: 421
🏁 Script executed:
# Check the file structure and prerequisites section
head -n 250 .gitbook/infra/join-a-network.mdx | tail -n 100Repository: InjectiveLabs/injective-docs
Length of output: 4459
🏁 Script executed:
# Look for any prerequisites or installation sections in the file
rg -n 'prerequisite|requirement|before you|install|setup|preparation' .gitbook/infra/join-a-network.mdx -iRepository: InjectiveLabs/injective-docs
Length of output: 1498
🏁 Script executed:
# Check if there are other related documentation files that might cover AWS CLI setup
fd -e mdx .gitbook/infra | head -20Repository: InjectiveLabs/injective-docs
Length of output: 528
🏁 Script executed:
# List files in .gitbook/infra directory
fd . '.gitbook/infra' -e mdxRepository: InjectiveLabs/injective-docs
Length of output: 3217
🏁 Script executed:
# Check the beginning of the file for any prerequisites section
head -n 100 .gitbook/infra/join-a-network.mdxRepository: InjectiveLabs/injective-docs
Length of output: 5216
🏁 Script executed:
# Search for AWS CLI setup instructions in the entire .gitbook directory
rg -i 'aws.*install|install.*aws|aws.*prerequisite|apt.*awscli|brew.*awscli' .gitbook --type mdxRepository: InjectiveLabs/injective-docs
Length of output: 194
🏁 Script executed:
# Search for AWS references in .gitbook directory (ignore file type restriction)
rg -i 'aws' .gitbook/infra --no-type -A 2 -B 2Repository: InjectiveLabs/injective-docs
Length of output: 602
🏁 Script executed:
# Look at the section right before the AWS command (lines 200-240)
sed -n '200,240p' .gitbook/infra/join-a-network.mdxRepository: InjectiveLabs/injective-docs
Length of output: 1911
🏁 Script executed:
# Check if there's a prerequisites or requirements section at the top of the file
sed -n '1,50p' .gitbook/infra/join-a-network.mdxRepository: InjectiveLabs/injective-docs
Length of output: 2136
Add AWS CLI installation prerequisite before the S3 download step
The aws s3 cp command at line 234 requires AWS CLI to be preinstalled, but no installation instructions are documented. Users on fresh hosts will encounter a command-not-found error. Add an explicit prerequisite (e.g., apt-get install awscli for Linux, brew install awscli for macOS) before this step to ensure the guide succeeds on all platforms.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.gitbook/infra/join-a-network.mdx around lines 233 - 235, Add AWS CLI
installation instructions as a prerequisite step before the aws s3 cp command
that downloads the genesis file. Include installation commands for multiple
platforms (such as apt-get install awscli for Linux distributions and brew
install awscli for macOS) to ensure users on fresh hosts can successfully
execute the aws s3 cp command without encountering command-not-found errors.
Place these installation instructions in a new prerequisite section that appears
before the step containing the aws s3 cp --no-sign-request
s3://injective-snapshots/testnet/genesis.json command.
Also, the link redirects to Alchemy
1 participant
Summary by CodeRabbit
genesis.json, updating required parameters, and adding checksum verification.LimitNOFILEin the relevantsystemdservice units.