chore: prep for v1.20.1-beta#19
Open
dbrajovic wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthroughThis PR updates top-level ignore/version-tag metadata and expands several protobuf APIs and schemas across exchange, RFQ, derivatives, and Peggy definitions. ChangesRepository maintenance
Proto API updates
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@all_protos/exchange/injective_chart_rpc.proto`:
- Around line 98-100: The doc comment on the Injective chart RPC proto field
uses camelCase names that do not match the message’s snake_case fields. Update
the comment on index_prices so it refers to use_oracle_prices and fill_gaps
instead of useOraclePrices and fillGaps, keeping the wording aligned with the
actual proto symbols.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6e49919d-e058-479e-a8ac-f8a1ca9ba6e5
⛔ Files ignored due to path filters (5)
cpp_protos.zipis excluded by!**/*.zipcsharp_protos.zipis excluded by!**/*.zipjava_protos.zipis excluded by!**/*.zippython_protos.zipis excluded by!**/*.ziprust_protos.zipis excluded by!**/*.zip
📒 Files selected for processing (9)
.gitignoreMakefileall_protos/exchange/injective_chart_rpc.protoall_protos/exchange/injective_exchange_rpc.protoall_protos/exchange/injective_rfq_gw_rpc.protoall_protos/exchange/injective_rfq_rpc.protoall_protos/exchange/injective_tc_derivatives_rpc.protoall_protos/injective/peggy/v1/msgs.protoall_protos/injective/peggy/v1/rate_limit.proto
Comment on lines
+98
to
+100
| // When true, we'll use index prices. Supersedes useOraclePrices and fillGaps. | ||
| // Disabled for binary options markets. | ||
| bool index_prices = 9; |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Comment uses camelCase field names that don't match the proto fields.
The doc references useOraclePrices and fillGaps, but the actual fields in this message are use_oracle_prices and fill_gaps. Align the comment with the snake_case proto names for clarity.
📝 Proposed doc fix
- // When true, we'll use index prices. Supersedes useOraclePrices and fillGaps.
-// Disabled for binary options markets.
+ // When true, we'll use index prices. Supersedes use_oracle_prices and fill_gaps.
+// Disabled for binary options markets.
bool index_prices = 9;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| // When true, we'll use index prices. Supersedes useOraclePrices and fillGaps. | |
| // Disabled for binary options markets. | |
| bool index_prices = 9; | |
| // When true, we'll use index prices. Supersedes use_oracle_prices and fill_gaps. | |
| // Disabled for binary options markets. | |
| bool index_prices = 9; |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@all_protos/exchange/injective_chart_rpc.proto` around lines 98 - 100, The doc
comment on the Injective chart RPC proto field uses camelCase names that do not
match the message’s snake_case fields. Update the comment on index_prices so it
refers to use_oracle_prices and fill_gaps instead of useOraclePrices and
fillGaps, keeping the wording aligned with the actual proto symbols.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes
Chores