Skip to content

fix(eslint): preserve enum export and values in fixer #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ocheretovich wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(eslint): preserve enum export and values in fixer #626

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
897219b
fix(eslint): preserve enum export and values in fixer
Ocheretovich Mar 19, 2026
2592ea9
fix(eslint): avoid duplicate export in enum autofix
Ocheretovich Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/eslint-rules/no-enum.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@ export default {
const parentNode = node.parent
const isExported =
parentNode && parentNode.type === 'ExportNamedDeclaration'
const exportKeyword = isExported ? '' : 'export '
const exportKeyword = isExported ? 'export ' : ''
Comment thread
coderabbitai[bot] marked this conversation as resolved.

// Get the enum members
const members = node.members.map((member) => {
const key = member.id.name
const value = member.initializer
? sourceCode.getText(member.initializer)
: `'${key.toLowerCase()}'`

@ThomasRalee ThomasRalee Apr 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we want to remove .toLowerCase() ?

@Ocheretovich Ocheretovich Apr 13, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To preserve the original enum member value. Using toLowerCase() was changing it unexpectedly

: `'${key}'`
return { key, value }
})

Expand All @@ -58,7 +58,7 @@ ${constMembers},
messageId: 'preferTypeConst',
data: { enumName },
fix(fixer) {
return fixer.replaceText(node, suggestedCode)
return fixer.replaceText(isExported ? parentNode : node, suggestedCode)
},
})
},
Expand Down