Skip to content

Commit 8cd81f9

Browse files
authored
Merge pull request #214 from spier/fix-links-in-structured-patterns
Fix links between patterns
2 parents a3eb1a4 + e15d9e1 commit 8cd81f9

File tree

10 files changed

+20
-19
lines changed

10 files changed

+20
-19
lines changed

.github/workflows/main.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
# from: https://github.com/marketplace/actions/link-checker
2+
# link checker used is 'liche': https://github.com/raviqqe/liche
23

34
name: Link Check on README.md
45

@@ -12,6 +13,6 @@ jobs:
1213
id: lc
1314
uses: peter-evans/link-checker@v1
1415
with:
15-
args: -v -d . -x "http://creativecommons.org/licenses|https://isc-inviter.herokuapp.com" README.md
16+
args: -v -d . -x "http://creativecommons.org/licenses|https://isc-inviter.herokuapp.com|https://github.com/rcs/rcs-viewer/pull/81" README.md patterns/ -r
1617
- name: Fail if there were link errors
1718
run: exit ${{ steps.lc.outputs.exit_code }}

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
The goal of the InnerSource patterns working group is to collect, document, and publish InnerSource best practices. To make the best practices easy to comprehend, evaluate, and apply, we codify them in a specific structure - [the patterns format](meta/pattern-template.md). More infos on the working group can be found in our [README.md](README.md) file.
44

5-
For this working group to strive, we welcome your contribution - be it small or huge.
5+
For this working group to strive, we welcome your contribution - be it small or huge.
66

77

88
## How to Contribute?
@@ -31,7 +31,7 @@ We are happy to support you in contributing to the InnerSource patterns or to ju
3131

3232
## License of Contributions
3333

34-
The contents of this repository are licensed under [CC-BY-SA-4.0](LICENSE.md). By contributing to this repository, you grant us (and everyone else for that matter) the right to use your contribution in accordance with that license.
34+
The contents of this repository are licensed under [CC-BY-SA-4.0](LICENSE.txt). By contributing to this repository, you grant us (and everyone else for that matter) the right to use your contribution in accordance with that license.
3535

3636

3737
## Code of Conduct

meta/innersource-spelling.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ We encourage you to use the word as a proper noun (like “We use InnerSource in
1010

1111
We favor the spelling **InnerSource**, for the following reasons:
1212

13-
1. That’s the way Tim O’Reilly [spelled it in 2000][opengl_1200] (he was into Perl and camel-case was a thing). Also see the [Foreword of the Adopting InnerSource book](foreword_AdoptingInnerSource) for more of Tim O’Reilly's own words on the topic.
13+
1. That’s the way Tim O’Reilly [spelled it in 2000][opengl_1200] (he was into Perl and camel-case was a thing). Also see the [Foreword of the Adopting InnerSource book][foreword_AdoptingInnerSource] for more of Tim O’Reilly's own words on the topic.
1414
2. If you set up side-by-side Google searches for “Inner Source” and “InnerSource” you will find that you get more hits on the former term, by only 1% of them have anything to do with what we call InnerSource. The latter term will be 100% cogent to your inquiry.
1515
3. The OSI was [denied trademark on the term “open source”][no-open-source-trademark] because it was made up of two common and unrelated terms. “InnerSource” on the other hand is a new word.
1616

meta/markdown-info.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
A markdown file is a plain ASCII text file that is meant to be easy to read in plaintext, while also being pretty once rendered.
44

5-
It is similar to the format that many wiki's have. As an example, you can see [this rendered pattern](../dedicated-community-leader.md) of ours also [in plain text](/../../raw/master/dedicated-community-leader.md). You can do this for any markdown file by clicking the ``Raw`` button when viewing a file online.
5+
It is similar to the format that many wiki's have. As an example, you can see [this rendered pattern](../patterns/2-structured/dedicated-community-leader.md) of ours also [in plain text](/../../raw/master/patterns/2-structured/dedicated-community-leader.md). You can do this for any markdown file by clicking the ``Raw`` button when viewing a file online.
66

77
The ASCII is marked up in a standard format. Here are two cheatsheets for that format:
88

meta/technical-git-howto.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
# Command-line git steps for creating a new Pattern
22

3-
If you want to contribute a new pattern, the workflow is done through Branches and Pull Requests (PR's). You can see the available branches on [the branches URL](https://github.com/InnerSourceCommons/InnerSourcePatterns/branches/all) and existing PR's on the [Pull Request page](https://github.com/InnerSourceCommons/InnerSourcePatterns/pulls). Branches are meant to separate content, so that multiple people can work all at once. Pull Requests (PR's) are used to bring discussion/review about a specific inner source pattern.
3+
If you want to contribute a new pattern, the workflow is done through Branches and Pull Requests (PR's). You can see the available branches on [the branches URL](https://github.com/InnerSourceCommons/InnerSourcePatterns/branches/all) and existing PR's on the [Pull Request page](https://github.com/InnerSourceCommons/InnerSourcePatterns/pulls). Branches are meant to separate content, so that multiple people can work all at once. Pull Requests (PR's) are used to bring discussion/review about a specific inner source pattern.
44

55
There are indeed multiple ways to start a discussion:
66

77
* Send a Pull Request for your branch and the maintainers will receive a notification.
88
* Create an Issue and ask for comments from some of the maintainers. You can mention them using the '@' symbol prior to their github nickname.
99
* Add reviewers to the Pull Request on the website - this sends requests to review your work
1010

11-
New patterns should use, as their base, the [pattern template file](meta/pattern-template.md).
11+
New patterns should use, as their base, the [pattern template file](pattern-template.md).
1212

1313
Please, when starting a new pattern, make sure that it does not already exist. Take a look at some of the [existing patterns in this repository](/README.md#reviewed-patterns-proven-and-reviewed).
1414

@@ -69,7 +69,7 @@ branch with a new pattern named as foo should be as follows:
6969
$ git checkout -b pattern/foo
7070
```
7171

72-
You are now in the 'pattern/foo' branch. When you create a new branch, the files
72+
You are now in the 'pattern/foo' branch. When you create a new branch, the files
7373
in the directory might appear to have changed. Each branch can have slightly different content, and that is intentional. If you need to go back to the 'master' branch or another branch, you can easily 'checkout' to those as follows:
7474

7575
```
@@ -87,7 +87,7 @@ $ git checkout -b pattern/ewoks-do-not-hunt
8787
$ touch ewoks-do-not-hunt.md
8888
```
8989

90-
You can fill your [markdown](meta/markdown-info.md) file with the [pattern template text](meta/pattern-template.md) and begin to fill it in with your pattern.
90+
You can fill your [markdown](markdown-info.md) file with the [pattern template text](pattern-template.md) and begin to fill it in with your pattern.
9191

9292
Once our pattern file is ready to go, we need to add the file to the repo and
9393
commit that change to our new branch.

patterns/2-structured/30-day-warranty.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,4 +79,4 @@ Drafted at the 2017 Spring InnerSource Summit; reviewed 18 July 2017.
7979
## Variants
8080

8181
- Ensure cooperation of dependent teams by making them a community by having
82-
more than one, meritocratically appointed "[Trusted Committers](project-roles/trusted-committer.md)" (TCs) take responsibility.
82+
more than one, meritocratically appointed "[Trusted Committers](./trusted-committer.md)" (TCs) take responsibility.

patterns/2-structured/contracted-contributor.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ empowering middle management to sign off on it:
111111
A formal contracting is also beneficial for contributors and communities:
112112

113113
- With a stable group of contributors, it is more likely that some of them will
114-
eventually achieve [Trusted Committer](project-roles/trusted-committer.md) status.
114+
eventually achieve [Trusted Committer](./trusted-committer.md) status.
115115
- A formal contracting provides a basis for resolving conflict related to
116116
participation in InnerSource activities. Note that mediation will likely be
117117
successful only for a few companies with a culture condusive to that.

patterns/2-structured/praise-participants.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ Praise and thanks are easy, affordable ways to keep contributors and their manag
1212
A pattern in this area makes it easy to do and ensures that the message comes across clearly and sincerely.
1313

1414
## Context
15-
* You are the [Trusted Committer](project-roles/trusted-committer.md) or maintainer on an inner source project.
15+
* You are the [Trusted Committer](./trusted-committer.md) or maintainer on an inner source project.
1616
* You value the community of contributors and want to maintain and grow it.
1717

1818
## Forces
@@ -52,7 +52,7 @@ Overdoing it may feel insincere and mechanical and defeat your purpose in reachi
5252

5353
## Related Patterns
5454

55-
* _Just Say Thanks_ (from the book [_Fearless Change_](http://www.fearlesschangepatterns.com/))
55+
* _Just Say Thanks_ (from the book [_Fearless Change_](https://fearlesschangepatterns.com/))
5656

5757
## Known Instances
5858

patterns/2-structured/start-as-experiment.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ or are actively developing Open Source software.
4444

4545
Declare the InnerSource initiative as a time limited experiment. Define and
4646
communicate the criteria for projects to join the InnerSource experiment. Choose
47-
criteria that will maximize the chances of building a healthy A set of criteria is
48-
a good one if the insights generated from it within the context of the experiment
47+
criteria that will maximize the chances of building a healthy A set of criteria is
48+
a good one if the insights generated from it within the context of the experiment
4949
can intuitively be applied to contexts involving other potential InnerSource projects.
5050
Examples for such criteria are:
5151

@@ -60,7 +60,7 @@ point to re-evaluate. Also consider establishing a [Review
6060
Committee](review-committee.md) to increase the chances of management buy-in
6161
through participation. Depending on company culture, it might be helpful to
6262
accompany the experiment with appropriate metrics [First Steps With
63-
Metrics](introducing-metrics-in-innersource.md). If the projects in the
63+
Metrics](../1-initial/introducing-metrics-in-innersource.md). If the projects in the
6464
experiment don't provide a direct impact on the companies revenue, consider
6565
introducing [Cross Team Valuation](crossteam-project-valuation.md) to highlight
6666
their value contributions.
@@ -79,7 +79,7 @@ Managers are able to kick start InnerSource for the following reasons:
7979
- In case of success, the data gathered during the experiment will allow
8080
managers to make a longer lasting commitment to InnerSource.
8181

82-
Participants in the InnerSource experiment are now conscious that they have to
82+
Participants in the InnerSource experiment are now conscious that they have to
8383
prove to management that InnerSource yields the promised benefits.
8484
It will therefore help to focus work on those activities which provide the most
8585
demonstrable value thus increasing the chances of success.
@@ -91,7 +91,7 @@ of success.
9191
## Related Patterns
9292

9393
- _Trial Run_ (from the book [_Fearless
94-
Change_](http://www.fearlesschangepatterns.com/))
94+
Change_](https://www.fearlesschangepatterns.com/))
9595

9696
## Known Instances
9797

patterns/2-structured/trusted-committer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,5 +165,5 @@ Published internally at Nike; drafted via pull-request in June of 2018.
165165
[Loren Sanz]: https://github.com/mrsanz
166166
[Jeremy Hicks]: https://github.com/greatestusername
167167
[Noah Cawley]: https://github.com/utanapishtim
168-
[praise]: /praise-participants.md
168+
[praise]: ./praise-participants.md
169169
[Fernando Freire]: https://github.com/dogonthehorizon

0 commit comments

Comments
 (0)