Moves goals 2025 to link to the top of the article instead of the middle#1016
Merged
andrea-kyurchiev merged 1 commit intoInnerSourceCommons:masterfrom Apr 25, 2025
Conversation
Collaborator
|
Thanks for doing this work. Have you tried the scenario and it works? |
Collaborator
Author
|
@rrrutledge yes, thats the whole point of the PR. You can pull it locally and test to review |
rrrutledge
approved these changes
Apr 25, 2025
Collaborator
rrrutledge
left a comment
rrrutledge
left a comment
There was a problem hiding this comment.
Thanks, @andrea-kyurchiev, looks good. I was reviewing from phone earlier and wasn't able to try it out myself. But if I know that you've tried it out then I'm happy to approve from phone even without trying it myself.
Collaborator
Author
|
@rrrutledge this is where it links to on my end: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes InnerSourceCommons/InnerSourceMarketing#397 (comment)