Skip to content

Ims 36#13

Merged
AHS12 merged 3 commits into
mainfrom
IMS-36
Jan 17, 2026
Merged

Ims 36#13
AHS12 merged 3 commits into
mainfrom
IMS-36

Conversation

@AHS12

@AHS12 AHS12 commented Jan 17, 2026

Copy link
Copy Markdown
Contributor

🚀 Pull Request

📋 Context & Description

  • Issue: JIRA-123 / #123
  • Motivation: Why is this change needed?

🛠️ Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ♻️ Refactor (code improvement/cleanup without logical changes)
  • 📚 Documentation update
  • 🔧 Chore (configuration, dependencies, CI/CD)

🧱 Laravel Specifics

  • 📜 Database Migrations: Are there new migrations? (Yes/No)
  • 🚦 Routes: Are there new API routes? (Yes/No)
  • 📦 Dependencies: Are there new Composer/NPM packages? (Yes/No)
  • Queue/Jobs: Does this involve queued jobs? (Yes/No)
  • 📢 Events/Listeners: Does this introduce new events? (Yes/No)
  • ⚙️ Config: Are there changes to configuration files? (Yes/No)

🧪 Testing Strategy

  • Unit/Feature Tests: Ran php artisan test
  • 🔍 Static Analysis: Ran phpstan or larastan
  • 🧹 Code Style: Ran pint or php-cs-fixer
  • 🖐️ Manual Testing: Describe steps below.

Manual Test Steps

  1. Step 1
  2. Step 2

📸 Screenshots (if applicable)

✅ Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation accordingly.
  • My changes generate no new warnings or errors.
  • I have added tests that prove my fix is effective or that my feature works.

🚀 Deployment Notes

AHS12 added 3 commits January 8, 2026 02:29
- Add missing error message for AUTH_ERROR_LOCKOUT case
- Replace apiErrorCode with direct errorCode in ApiException
- Standardize response codes for different error cases
@AHS12 AHS12 merged commit 67b4150 into main Jan 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants