test(cli): cover cli_posthog_invoked telemetry in posthog setup

Author: CarmenDou

src/commands/posthog/setup.test.ts

@@ -11,10 +11,15 @@ vi.mock('../../lib/api/posthog.js', () => apiMock);
 const configMock = vi.hoisted(() => ({
   getProjectConfig: vi.fn(() => ({ project_id: 'p1', project_name: 'Test Project' })),
   getAccessToken: vi.fn(() => 'tok'),
-  FAKE_PROJECT_ID: 'fa4e0000-1234-5678-90ab-cd1234567890',
 }));
 vi.mock('../../lib/config.js', () => configMock);
 
+const analyticsMock = vi.hoisted(() => ({
+  trackPosthog: vi.fn(),
+  shutdownAnalytics: vi.fn(async () => {}),
+}));
+vi.mock('../../lib/analytics.js', () => analyticsMock);
+
 vi.mock('../../lib/prompts.js', () => ({ isInteractive: false }));
 
 // `open` is loaded dynamically inside runConnectFlow; mock so the real browser
@@ -82,6 +87,8 @@ beforeEach(() => {
   outputMock.outputJson.mockReset();
   outputMock.outputSuccess.mockReset();
   clackNoteMock.mockReset();
+  analyticsMock.trackPosthog.mockReset();
+  analyticsMock.shutdownAnalytics.mockClear();
   configMock.getProjectConfig.mockReturnValue({ project_id: 'p1', project_name: 'Test Project' });
   configMock.getAccessToken.mockReturnValue('tok');
 });
@@ -176,4 +183,32 @@ describe('posthog setup', () => {
       expect(payload.wizardCommand).toMatch(/^npx(\.cmd)? -y @posthog\/wizard@latest$/);
     });
   });
+
+  describe('analytics', () => {
+    it('fires cli_posthog_invoked with the project config and flushes on success', async () => {
+      apiMock.startPosthogCliFlow.mockResolvedValue({ type: 'connected' });
+      apiMock.fetchPosthogConnection.mockResolvedValue({
+        kind: 'connected',
+        connection: { apiKey: 'phc_', host: 'h', posthogProjectId: '1' },
+      });
+
+      await runSetup(['--skip-browser']);
+
+      expect(analyticsMock.trackPosthog).toHaveBeenCalledOnce();
+      expect(analyticsMock.trackPosthog).toHaveBeenCalledWith(
+        'setup',
+        expect.objectContaining({ project_id: 'p1' }),
+      );
+      expect(analyticsMock.shutdownAnalytics).toHaveBeenCalledOnce();
+    });
+
+    it('still flushes analytics when setup fails', async () => {
+      apiMock.startPosthogCliFlow.mockResolvedValue({ type: 'connected' });
+      apiMock.fetchPosthogConnection.mockResolvedValue({ kind: 'not-connected' });
+
+      await runSetup(['--skip-browser']);
+
+      expect(analyticsMock.shutdownAnalytics).toHaveBeenCalledOnce();
+    });
+  });
 });

src/commands/posthog/setup.ts

@@ -86,8 +86,6 @@ async function runSetup(opts: RunSetupOpts): Promise<SetupResult> {
     throw new AuthError('Not logged in. Run `insforge login` first.');
   }
 
-  // Step 2 of the "dashboard connect → CLI posthog setup" funnel; pairs
-  // with backend `posthog_connect_started` joined on project_id.
   trackPosthog('setup', proj);
 
   if (!opts.json) {