-
Notifications
You must be signed in to change notification settings - Fork 4
Expand file tree
/
Copy pathLunaticXmlAdapterTest.java
More file actions
507 lines (406 loc) · 19.7 KB
/
Copy pathLunaticXmlAdapterTest.java
File metadata and controls
507 lines (406 loc) · 19.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
package fr.insee.genesis.controller.adapter;
import fr.insee.bpm.metadata.model.VariablesMap;
import fr.insee.genesis.controller.sources.xml.LunaticXmlCollectedData;
import fr.insee.genesis.controller.sources.xml.LunaticXmlOtherData;
import fr.insee.genesis.controller.sources.xml.LunaticXmlSurveyUnit;
import fr.insee.genesis.controller.sources.xml.ValueType;
import fr.insee.genesis.domain.model.surveyunit.DataState;
import fr.insee.genesis.domain.model.surveyunit.Mode;
import fr.insee.genesis.domain.model.surveyunit.SurveyUnitModel;
import fr.insee.genesis.domain.model.surveyunit.VariableModel;
import org.junit.jupiter.api.DisplayName;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import java.time.Instant;
import java.time.LocalDateTime;
import java.util.List;
import static org.assertj.core.api.Assertions.assertThat;
@DisplayName("LunaticXmlAdapter tests")
class LunaticXmlAdapterTest {
private static final String QUESTIONNAIRE_ID = "questionnaire-abc";
private static final String INTERROGATION_ID = "interrogation-123";
private static final Mode MODE = Mode.WEB;
private static final VariablesMap VARIABLES_MAP = new VariablesMap();
// -------------------------------------------------------------------------
// convert() — returned list composition
// -------------------------------------------------------------------------
@Nested
@DisplayName("convert() — list composition tests")
class ConvertListCompositionTests {
@Test
@DisplayName("Should always include COLLECTED state in the result")
void convert_shouldAlwaysIncludeCollected() {
// GIVEN
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(collectedDataWithValue("VAR1", "val")));
// WHEN
List<SurveyUnitModel> result = LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE);
// THEN
assertThat(result).extracting(SurveyUnitModel::getState)
.contains(DataState.COLLECTED);
}
@Test
@DisplayName("Should return only COLLECTED when no other state has data")
void convert_noOtherStateData_shouldReturnOnlyCollected() {
// GIVEN
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(collectedDataWithValue("VAR1", "val")));
// WHEN
List<SurveyUnitModel> result = LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE);
// THEN
assertThat(result).hasSize(1);
assertThat(result.getFirst().getState()).isEqualTo(DataState.COLLECTED);
}
@Test
@DisplayName("Should include EDITED state when it has data")
void convert_withEditedData_shouldIncludeEdited() {
// GIVEN
LunaticXmlCollectedData data = new LunaticXmlCollectedData();
data.setVariableName("VAR1");
data.setCollected(List.of(getValueType("collected-val")));
data.setEdited(List.of(getValueType("edited-val")));
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(data));
// WHEN
List<SurveyUnitModel> result = LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE);
// THEN
assertThat(result).extracting(SurveyUnitModel::getState)
.contains(DataState.COLLECTED, DataState.EDITED);
}
@Test
@DisplayName("Should include INPUTED state when it has data")
void convert_withInputedData_shouldIncludeInputed() {
// GIVEN
LunaticXmlCollectedData data = new LunaticXmlCollectedData();
data.setVariableName("VAR1");
data.setCollected(List.of(getValueType("val")));
data.setInputed(List.of(getValueType("inputed-val")));
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(data));
// WHEN
List<SurveyUnitModel> result = LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE);
// THEN
assertThat(result).extracting(SurveyUnitModel::getState)
.contains(DataState.INPUTED);
}
@Test
@DisplayName("Should include FORCED state when it has data")
void convert_withForcedData_shouldIncludeForced() {
// GIVEN
LunaticXmlCollectedData data = new LunaticXmlCollectedData();
data.setVariableName("VAR1");
data.setCollected(List.of(getValueType("val")));
data.setForced(List.of(getValueType("forced-val")));
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(data));
// WHEN
List<SurveyUnitModel> result = LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE);
// THEN
assertThat(result).extracting(SurveyUnitModel::getState)
.contains(DataState.FORCED);
}
@Test
@DisplayName("Should include PREVIOUS state when it has data")
void convert_withPreviousData_shouldIncludePrevious() {
// GIVEN
LunaticXmlCollectedData data = new LunaticXmlCollectedData();
data.setVariableName("VAR1");
data.setCollected(List.of(getValueType("val")));
data.setPrevious(List.of(getValueType("previous-val")));
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(data));
// WHEN
List<SurveyUnitModel> result = LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE);
// THEN
assertThat(result).extracting(SurveyUnitModel::getState)
.contains(DataState.PREVIOUS);
}
@Test
@DisplayName("Should include all 5 states when all have data")
void convert_allStatesHaveData_shouldReturnFiveModels() {
// GIVEN
LunaticXmlCollectedData data = new LunaticXmlCollectedData();
data.setVariableName("VAR1");
data.setCollected(List.of(getValueType("c")));
data.setEdited(List.of(getValueType("e")));
data.setInputed(List.of(getValueType("i")));
data.setForced(List.of(getValueType("f")));
data.setPrevious(List.of(getValueType("p")));
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(data));
// WHEN
List<SurveyUnitModel> result = LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE);
// THEN
assertThat(result).hasSize(5);
assertThat(result).extracting(SurveyUnitModel::getState)
.containsExactlyInAnyOrder(
DataState.COLLECTED, DataState.EDITED,
DataState.INPUTED, DataState.FORCED, DataState.PREVIOUS);
}
@Test
@DisplayName("Should not include EDITED when its values are all null")
void convert_editedAllNullValues_shouldNotIncludeEdited() {
// GIVEN
LunaticXmlCollectedData data = new LunaticXmlCollectedData();
data.setVariableName("VAR1");
data.setCollected(List.of(getValueType("val")));
data.setEdited(List.of(getValueType(null))); // null value — no data
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(data));
// WHEN
List<SurveyUnitModel> result = LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE);
// THEN
assertThat(result).extracting(SurveyUnitModel::getState).isNotEmpty()
.doesNotContain(DataState.EDITED);
}
}
// -------------------------------------------------------------------------
// convert() — field mapping
// -------------------------------------------------------------------------
@Nested
@DisplayName("convert() — field mapping tests")
class ConvertFieldMappingTests {
@Test
@DisplayName("Should map questionnaireModelId to collectionInstrumentId in uppercase")
void convert_shouldMapQuestionnaireIdUppercased() {
// GIVEN
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(collectedDataWithValue("VAR1", "val")));
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
assertThat(collected.getCollectionInstrumentId()).isEqualTo(QUESTIONNAIRE_ID.toUpperCase());
}
@Test
@DisplayName("Should map interrogation id")
void convert_shouldMapInterrogationId() {
// GIVEN
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(collectedDataWithValue("VAR1", "val")));
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
assertThat(collected.getInterrogationId()).isEqualTo(INTERROGATION_ID);
}
@Test
@DisplayName("Should map mode")
void convert_shouldMapMode() {
// GIVEN
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(collectedDataWithValue("VAR1", "val")));
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
assertThat(collected.getMode()).isEqualTo(MODE);
}
@Test
@DisplayName("Should set a non-null recordDate close to now")
void convert_shouldSetRecordDateCloseToNow() {
// GIVEN
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(collectedDataWithValue("VAR1", "val")));
Instant before = Instant.now();
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
Instant after = Instant.now();
assertThat(collected.getRecordDate())
.isNotNull()
.isAfterOrEqualTo(before)
.isBeforeOrEqualTo(after);
}
@Test
@DisplayName("Should map rawRecordDate from survey unit")
void convert_shouldMapRawRecordDate() {
// GIVEN
LocalDateTime rawRecordDate = LocalDateTime.of(2024, 1, 15, 10, 0);
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(collectedDataWithValue("VAR1", "val")));
su.setRawRecordDate(rawRecordDate);
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
assertThat(collected.getRawRecordDate()).isEqualTo(rawRecordDate);
}
}
// -------------------------------------------------------------------------
// convert() — collected variables
// -------------------------------------------------------------------------
@Nested
@DisplayName("convert() — collected variables tests")
class ConvertCollectedVariablesTests {
@Test
@DisplayName("Should populate collectedVariables from COLLECTED data")
void convert_shouldPopulateCollectedVariables() {
// GIVEN
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(
collectedDataWithValue("VAR1", "value1")
));
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
assertThat(collected.getCollectedVariables()).hasSize(1);
assertThat(collected.getCollectedVariables().getFirst().varId()).isEqualTo("VAR1");
assertThat(collected.getCollectedVariables().getFirst().value()).isEqualTo("value1");
}
@Test
@DisplayName("Should set iteration starting at 1 for each value")
void convert_shouldSetIterationStartingAtOne() {
// GIVEN
LunaticXmlCollectedData data = new LunaticXmlCollectedData();
data.setVariableName("VAR1");
data.setCollected(List.of(getValueType("val1"), getValueType("val2")));
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(data));
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
assertThat(collected.getCollectedVariables()).hasSize(2);
assertThat(collected.getCollectedVariables().get(0).iteration()).isEqualTo(1);
assertThat(collected.getCollectedVariables().get(1).iteration()).isEqualTo(2);
}
@Test
@DisplayName("Should skip collected variables with null value")
void convert_shouldSkipNullValues() {
// GIVEN
LunaticXmlCollectedData data = new LunaticXmlCollectedData();
data.setVariableName("VAR1");
data.setCollected(List.of(getValueType("val"), getValueType(null)));
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(data));
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
assertThat(collected.getCollectedVariables()).hasSize(1);
assertThat(collected.getCollectedVariables().getFirst().value()).isEqualTo("val");
}
@Test
@DisplayName("Should produce empty collectedVariables when collected list is null for a variable")
void convert_nullCollectedList_shouldProduceEmptyVariables() {
// GIVEN
LunaticXmlCollectedData data = new LunaticXmlCollectedData();
data.setVariableName("VAR1");
data.setCollected(null); // null list — skipped
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(data));
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
assertThat(collected.getCollectedVariables()).isEmpty();
}
@Test
@DisplayName("Should handle multiple variables in the collected data")
void convert_multipleVariables_shouldMapAll() {
// GIVEN
LunaticXmlSurveyUnit su = buildSurveyUnit(List.of(
collectedDataWithValue("VAR1", "v1"),
collectedDataWithValue("VAR2", "v2")
));
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
assertThat(collected.getCollectedVariables()).hasSize(2);
assertThat(collected.getCollectedVariables())
.extracting(VariableModel::varId)
.containsExactlyInAnyOrder("VAR1", "VAR2");
}
}
// -------------------------------------------------------------------------
// convert() — external variables
// -------------------------------------------------------------------------
@Nested
@DisplayName("convert() — external variables tests")
class ConvertExternalVariablesTests {
@Test
@DisplayName("Should populate externalVariables on the COLLECTED model")
void convert_shouldPopulateExternalVariables() {
// GIVEN
LunaticXmlOtherData external = new LunaticXmlOtherData();
external.setVariableName("EXT1");
external.setValues(List.of(getValueType("ext-value")));
LunaticXmlSurveyUnit su = buildSurveyUnit(
List.of(collectedDataWithValue("VAR1", "v")),
List.of(external)
);
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
assertThat(collected.getExternalVariables()).hasSize(1);
assertThat(collected.getExternalVariables().getFirst().varId()).isEqualTo("EXT1");
assertThat(collected.getExternalVariables().getFirst().value()).isEqualTo("ext-value");
}
@Test
@DisplayName("Should skip external variables with null value")
void convert_externalNullValue_shouldSkip() {
// GIVEN
LunaticXmlOtherData external = new LunaticXmlOtherData();
external.setVariableName("EXT1");
external.setValues(List.of(getValueType(null)));
LunaticXmlSurveyUnit su = buildSurveyUnit(
List.of(collectedDataWithValue("VAR1", "v")),
List.of(external)
);
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
assertThat(collected.getExternalVariables()).isEmpty();
}
@Test
@DisplayName("Should skip external variable when values list is null")
void convert_externalNullValuesList_shouldSkip() {
// GIVEN
LunaticXmlOtherData external = new LunaticXmlOtherData();
external.setVariableName("EXT1");
external.setValues(null);
LunaticXmlSurveyUnit su = buildSurveyUnit(
List.of(collectedDataWithValue("VAR1", "v")),
List.of(external)
);
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
assertThat(collected.getExternalVariables()).isEmpty();
}
@Test
@DisplayName("Should set iteration starting at 1 for external variables")
void convert_externalVariables_shouldSetIteration() {
// GIVEN
LunaticXmlOtherData external = new LunaticXmlOtherData();
external.setVariableName("EXT1");
external.setValues(List.of(getValueType("v1"), getValueType("v2")));
LunaticXmlSurveyUnit su = buildSurveyUnit(
List.of(collectedDataWithValue("VAR1", "v")),
List.of(external)
);
// WHEN
SurveyUnitModel collected = getCollected(LunaticXmlAdapter.convert(su, VARIABLES_MAP, MODE));
// THEN
assertThat(collected.getExternalVariables()).hasSize(2);
assertThat(collected.getExternalVariables().get(0).iteration()).isEqualTo(1);
assertThat(collected.getExternalVariables().get(1).iteration()).isEqualTo(2);
}
}
// -------------------------------------------------------------------------
// Helpers
// -------------------------------------------------------------------------
private LunaticXmlSurveyUnit buildSurveyUnit(List<LunaticXmlCollectedData> collectedData) {
return buildSurveyUnit(collectedData, List.of());
}
private LunaticXmlSurveyUnit buildSurveyUnit(
List<LunaticXmlCollectedData> collectedData,
List<LunaticXmlOtherData> externalData) {
LunaticXmlSurveyUnit su = new LunaticXmlSurveyUnit();
su.setId(INTERROGATION_ID);
su.setQuestionnaireModelId(QUESTIONNAIRE_ID);
fr.insee.genesis.controller.sources.xml.LunaticXmlData data =
new fr.insee.genesis.controller.sources.xml.LunaticXmlData();
data.setCollected(collectedData);
data.setExternal(externalData);
su.setData(data);
return su;
}
private LunaticXmlCollectedData collectedDataWithValue(String varName, String value) {
LunaticXmlCollectedData data = new LunaticXmlCollectedData();
data.setVariableName(varName);
data.setCollected(List.of(getValueType(value)));
return data;
}
private ValueType getValueType(String value) {
ValueType vt = new ValueType(
value,
"STRING"
);
vt.setValue(value);
return vt;
}
private SurveyUnitModel getCollected(List<SurveyUnitModel> models) {
return models.stream()
.filter(m -> m.getState() == DataState.COLLECTED)
.findFirst()
.orElseThrow(() -> new AssertionError("No COLLECTED model found"));
}
}