Skip to content

Commit 1fcbf23

Browse files
committed
chore: remove sonar code smells
1 parent 0ace484 commit 1fcbf23

2 files changed

Lines changed: 2 additions & 7 deletions

File tree

src/test/java/fr/insee/genesis/controller/rest/responses/ResponseControllerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ void getLatestForUEListTest() {
238238

239239
// Perret tests
240240
@Test
241-
void getLatestByStatesSurveyDataTest() throws GenesisException, IOException {
241+
void getLatestByStatesSurveyDataTest() throws GenesisException {
242242
//GIVEN
243243
//Recent Collected already in stub
244244
//Old Collected

src/test/java/fr/insee/genesis/stubs/SurveyUnitPersistencePortStub.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ public List<SurveyUnitModel> findByIds(String interrogationId, String questionna
3535
* @author Adrien Marchal
3636
*/
3737
public List<SurveyUnitModel> findBySetOfIdsAndQuestionnaireIdAndMode(String questionnaireId, String mode, List<String> interrogationIdSet) {
38-
//TODO : TO BE IMPLEMENTED
3938
return new ArrayList<SurveyUnitModel>();
4039
}
4140
//========= OPTIMISATIONS PERFS (START) ==========
@@ -102,11 +101,7 @@ public long countInterrogationIdsByQuestionnaireId(String questionnaireId) {
102101
* @author Adrien Marchal
103102
*/
104103
public List<SurveyUnitModel> findPageableInterrogationIdsByQuestionnaireId(String questionnaireId, Long skip, Long limit) {
105-
List<SurveyUnitModel> surveyUnitModelList = new ArrayList<>();
106-
if(skip < mongoStub.size()) {
107-
108-
}
109-
return surveyUnitModelList;
104+
return List.of();
110105
}
111106
//======= OPTIMISATIONS PERFS (END) =========
112107

0 commit comments

Comments
 (0)