Skip to content

Commit 5d96f67

Browse files
committed
feat: Upper case questionnaireIds sent to DB
1 parent 31b4abc commit 5d96f67

6 files changed

Lines changed: 8 additions & 10 deletions

File tree

src/main/java/fr/insee/genesis/controller/adapter/LunaticXmlAdapter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ public static List<SurveyUnitModel> convert(LunaticXmlSurveyUnit su, VariablesMa
6969
*/
7070
private static SurveyUnitModel getStateDataFromSurveyUnit(LunaticXmlSurveyUnit su, VariablesMap variablesMap, String campaignId, DataState dataState, Mode mode) {
7171
SurveyUnitModel surveyUnitModel = SurveyUnitModel.builder()
72-
.questionnaireId(su.getQuestionnaireModelId())
72+
.questionnaireId(su.getQuestionnaireModelId().toUpperCase())
7373
.campaignId(campaignId)
7474
.interrogationId(su.getId())
7575
.state(dataState)

src/main/java/fr/insee/genesis/controller/rest/LunaticModelController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public ResponseEntity<String> saveRawResponsesFromJsonBody(
3636
@RequestParam("questionnaireId") String questionnaireId,
3737
@RequestBody Map<String, Object> dataJson
3838
){
39-
lunaticModelApiPort.save(questionnaireId, dataJson);
39+
lunaticModelApiPort.save(questionnaireId.toUpperCase(), dataJson);
4040
return ResponseEntity.ok().build();
4141
}
4242

src/main/java/fr/insee/genesis/controller/rest/responses/EditedResponseController.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public ResponseEntity<Object> readEditedPreviousJson(
6767
if (!jsonFileName.toLowerCase().endsWith(".json")) {
6868
throw new GenesisException(400, "File must be a JSON file !");
6969
}
70-
readEditedPreviousFile(questionnaireId, sourceState, filePath);
70+
readEditedPreviousFile(questionnaireId.toUpperCase(), sourceState, filePath);
7171
moveFiles(questionnaireId, mode, fileUtils, filePath);
7272
return ResponseEntity.ok("Edited previous variable file %s saved !".formatted(filePath));
7373
}catch (GenesisException ge){
@@ -93,7 +93,7 @@ public ResponseEntity<Object> readEditedExternalJson(
9393
if (!jsonFileName.toLowerCase().endsWith(".json")) {
9494
throw new GenesisException(400, "File must be a JSON file !");
9595
}
96-
readEditedExternalFile(questionnaireId, filePath);
96+
readEditedExternalFile(questionnaireId.toUpperCase(), filePath);
9797
moveFiles(questionnaireId, mode, fileUtils, filePath);
9898
return ResponseEntity.ok("Edited external variable file %s saved !".formatted(filePath));
9999
}catch (GenesisException ge){

src/main/java/fr/insee/genesis/controller/rest/responses/RawResponseController.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public ResponseEntity<String> saveRawResponsesFromJsonBody(
7070
log.info("Try to save interrogationId {} for campaign {}", interrogationId, campaignName);
7171
LunaticJsonRawDataModel rawData = LunaticJsonRawDataModel.builder()
7272
.campaignId(campaignName)
73-
.questionnaireId(questionnaireId)
73+
.questionnaireId(questionnaireId.toUpperCase())
7474
.interrogationId(interrogationId)
7575
.idUE(idUE)
7676
.mode(modeSpecified)
@@ -118,7 +118,7 @@ public ResponseEntity<String> saveRawResponsesFromJsonBodyWithValidation(
118118

119119
LunaticJsonRawDataModel rawData = LunaticJsonRawDataModel.builder()
120120
.campaignId(body.get(PARTITION_ID).toString())
121-
.questionnaireId(body.get("questionnaireModelId").toString())
121+
.questionnaireId(body.get("questionnaireModelId").toString().toUpperCase())
122122
.interrogationId(body.get(INTERROGATION_ID).toString())
123123
.idUE(body.get("surveyUnitId").toString())
124124
.mode(Mode.getEnumFromJsonName(body.get("mode").toString()))

src/main/java/fr/insee/genesis/controller/rest/responses/ResponseController.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import fr.insee.bpm.metadata.reader.lunatic.LunaticReader;
77
import fr.insee.genesis.Constants;
88
import fr.insee.genesis.controller.adapter.LunaticXmlAdapter;
9-
import fr.insee.genesis.domain.model.surveyunit.InterrogationId;
109
import fr.insee.genesis.controller.dto.SurveyUnitDto;
1110
import fr.insee.genesis.controller.dto.SurveyUnitInputDto;
1211
import fr.insee.genesis.controller.dto.SurveyUnitQualityToolDto;
@@ -21,6 +20,7 @@
2120
import fr.insee.genesis.controller.utils.ControllerUtils;
2221
import fr.insee.genesis.controller.utils.DataTransformer;
2322
import fr.insee.genesis.domain.model.context.DataProcessingContextModel;
23+
import fr.insee.genesis.domain.model.surveyunit.InterrogationId;
2424
import fr.insee.genesis.domain.model.surveyunit.Mode;
2525
import fr.insee.genesis.domain.model.surveyunit.SurveyUnitModel;
2626
import fr.insee.genesis.domain.model.surveyunit.VariableModel;
@@ -57,11 +57,9 @@
5757
import java.nio.file.Files;
5858
import java.nio.file.Path;
5959
import java.nio.file.Paths;
60-
import java.time.LocalDateTime;
6160
import java.util.ArrayList;
6261
import java.util.List;
6362
import java.util.Set;
64-
import java.util.stream.Stream;
6563

6664
@RequestMapping(path = "/responses" )
6765
@Controller

src/main/java/fr/insee/genesis/domain/service/surveyunit/SurveyUnitService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ public List<SurveyUnitModel> parseEditedVariables(
441441
SurveyUnitModel surveyUnitModel = SurveyUnitModel.builder()
442442
.campaignId(surveyUnitInputDto.getCampaignId())
443443
.mode(surveyUnitInputDto.getMode())
444-
.questionnaireId(surveyUnitInputDto.getQuestionnaireId())
444+
.questionnaireId(surveyUnitInputDto.getQuestionnaireId().toUpperCase())
445445
.interrogationId(surveyUnitInputDto.getInterrogationId())
446446
.state(state)
447447
.recordDate(LocalDateTime.now())

0 commit comments

Comments
 (0)