test: fixed unit tests

Author: alexisszmundy

src/test/java/cucumber/functional_tests/MainDefinitions.java

@@ -191,15 +191,15 @@ public void delete_directory() throws IOException {
 
     @When("We extract survey unit data with questionnaireId {string} and interrogationId {string}")
     public void extract_survey_data(String questionnaireId, String interrogationId) {
-        this.surveyUnitModelResponse = responseController.getLatestByInterrogation(interrogationId, questionnaireId);
+        this.surveyUnitModelResponse = responseController.getLatestByInterrogation(interrogationId, questionnaireId.toUpperCase());
     }
 
     @When("We extract survey unit latest states with questionnaireId {string} and interrogationId {string}")
     public void extract_survey_unit_latest_states(String questionnaireId, String interrogationId){
         try {
             this.surveyUnitLatestStatesResponse =
                     responseController.findResponsesByInterrogationAndQuestionnaireLatestStates(interrogationId,
-                    questionnaireId);
+                    questionnaireId.toUpperCase());
         } catch (GenesisException e) {
             this.surveyUnitLatestStatesResponse = ResponseEntity.status(e.getStatus()).body(new ApiError(e.getMessage()));
         }
@@ -329,7 +329,7 @@ public void check_external_variable_content_in_mongo(
     @Then("If we get latest states for {string} in collected variable {string}, survey unit {string} we should have {string} for iteration {int}")
     public void check_latest_state_collected(String questionnaireId, String variableName, String interrogationId, String expectedValue, int iteration) throws GenesisException {
         ResponseEntity<Object> response =
-                responseController.findResponsesByInterrogationAndQuestionnaireLatestStates(interrogationId, questionnaireId);
+                responseController.findResponsesByInterrogationAndQuestionnaireLatestStates(interrogationId, questionnaireId.toUpperCase());
         Assertions.assertThat(response.getStatusCode().value()).isEqualTo(200);
 
         SurveyUnitQualityToolDto surveyUnitQualityToolDto = (SurveyUnitQualityToolDto) response.getBody();
@@ -353,7 +353,7 @@ public void check_latest_state_collected(String questionnaireId, String variable
     @Then("If we get latest states for {string} in external variable {string}, survey unit {string} we should have {string} for iteration {int}")
     public void check_latest_state_external(String questionnaireId, String variableName, String interrogationId, String expectedValue, int iteration) throws GenesisException {
         ResponseEntity<Object> response =
-                responseController.findResponsesByInterrogationAndQuestionnaireLatestStates(interrogationId, questionnaireId);
+                responseController.findResponsesByInterrogationAndQuestionnaireLatestStates(interrogationId, questionnaireId.toUpperCase());
         Assertions.assertThat(response.getStatusCode().value()).isEqualTo(200);
         SurveyUnitQualityToolDto surveyUnitQualityToolDto = (SurveyUnitQualityToolDto) response.getBody();
 

src/test/java/fr/insee/genesis/controller/adapter/LunaticXmlAdapterTest.java

@@ -234,7 +234,7 @@ void test02() {
         // When
         List<SurveyUnitModel> surveyUnitModels = LunaticXmlAdapter.convert(lunaticXmlSurveyUnit1, metadataModel.getVariables(), CAMPAIGN_ID, Mode.WEB);
         // Then
-        Assertions.assertThat(surveyUnitModels.getFirst().getQuestionnaireId()).isEqualTo("questionnaireId1");
+        Assertions.assertThat(surveyUnitModels.getFirst().getQuestionnaireId()).isEqualTo("questionnaireId1".toUpperCase());
     }
 
     @Test

src/test/java/fr/insee/genesis/controller/rest/responses/RawResponseControllerTest.java

@@ -61,7 +61,7 @@ void saveJsonRawDataFromStringTest() throws Exception {
         //GIVEN
         lunaticJsonRawDataPersistanceStub.getMongoStub().clear();
         String campaignId = "SAMPLETEST-PARADATA-v1";
-        String questionnaireId = "testIdQuest";
+        String questionnaireId = "testIdQuest".toUpperCase();
         String interrogationId = "testinterrogationId";
         Map<String,Object> json = JsonUtils.jsonToMap("{\"COLLECTED\": {\"testdata\": {\"COLLECTED\": [\"test\"]}}}");
 

src/test/java/fr/insee/genesis/controller/rest/responses/ResponseControllerTest.java

@@ -51,7 +51,7 @@ class ResponseControllerTest {
     static final String DEFAULT_INTERROGATION_ID = "TESTINTERROGATIONID";
     static final String DEFAULT_QUESTIONNAIRE_ID = "TESTQUESTIONNAIREID";
     static final String CAMPAIGN_ID_WITH_DDI = "SAMPLETEST-PARADATA-v1";
-    static final String QUESTIONNAIRE_ID_WITH_DDI = "SAMPLETEST-PARADATA-v1";
+    static final String QUESTIONNAIRE_ID_WITH_DDI = "SAMPLETEST-PARADATA-v1".toUpperCase();
 
     @BeforeAll
     static void init() {