refactor: fix some sonar issues

Author: nsenave

src/main/java/fr/insee/genesis/domain/ports/api/LunaticJsonRawDataApiPort.java

@@ -41,6 +41,9 @@ DataProcessResult reprocessRawData(
 
     List<LunaticJsonRawDataModel> getRawDataByInterrogationId(String interrogationId);
 
+    /**
+     * @deprecated Use the method with 'collectionInstrumentId' instead.
+     */
     @Deprecated(since = "1.13.0")
     DataProcessResult processRawData(String campaignName, List<String> interrogationIdList, List<GenesisError> errors) throws GenesisException;
 

src/main/java/fr/insee/genesis/domain/service/rawdata/LunaticJsonRawDataService.java

@@ -112,6 +112,9 @@ public List<LunaticJsonRawDataModel> getRawDataByInterrogationId(String interrog
         return lunaticJsonRawDataPersistencePort.findRawDataByInterrogationID(interrogationId);
     }
 
+    /**
+     * @deprecated Use the method with 'collectionInstrumentId' instead.
+     */
     @Override
     @Deprecated(since = "1.13.0")
     public DataProcessResult processRawData(String questionnaireId, List<String> interrogationIdList, List<GenesisError> errors) throws GenesisException {

src/test/java/fr/insee/genesis/domain/service/rawdata/LunaticJsonRawDataServiceTest.java

@@ -707,8 +707,8 @@ void reprocessRawData_should_return_empty_result_when_no_processed_interrogation
 
         // THEN
         Assertions.assertThat(result).isNotNull();
-        Assertions.assertThat(result.dataCount()).isEqualTo(0);
-        Assertions.assertThat(result.formattedDataCount()).isEqualTo(0);
+        Assertions.assertThat(result.dataCount()).isZero();
+        Assertions.assertThat(result.formattedDataCount()).isZero();
         Assertions.assertThat(result.errors()).isEmpty();
     }