Fix missing filter var#357
Merged
Merged
Conversation
alicela
reviewed
Dec 17, 2025
| } | ||
| return questionnaireMetadataModels.getFirst().metadataModel(); | ||
|
|
||
| saveMetadata(questionnaireId.toUpperCase(), mode, metadataModel); |
Contributor
There was a problem hiding this comment.
you don't have to save if the metadata are already stored
Contributor
Author
There was a problem hiding this comment.
You're right i have modified, thank you
|
|
||
| if (questionnaireMetadataModels.isEmpty() || questionnaireMetadataModels.getFirst().metadataModel() == null) { | ||
| metadataModel = readMetadatas(campaignName, mode.getModeName(), fileUtils, errors); | ||
| } else { |
Contributor
There was a problem hiding this comment.
avoid else if not necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for missing and filter variables in metadata by merging Lunatic data into the existing DDI metadata.