Dev/combined rawdata#367
Merged
Merged
Conversation
alexisszmundy
requested changes
Dec 23, 2025
Contributor
There was a problem hiding this comment.
suggestion: Rename it to combinedRawDataModel and create a similar DTO classed returned in the controller
| List<String> findInterrogationIdByCollectionInstrumentIdAndProcessDateIsNull(String collectionInstrumentId); | ||
|
|
||
| @Query(value = "{ 'interrogationId': ?0}") | ||
| List<RawResponseDocument> findByInterrogationId(String interrogationId); |
Contributor
There was a problem hiding this comment.
todo: add "@indexed" to interrogationId in rawResponseDocument
| List<LunaticJsonRawDataDocument> findModesByCampaignIdAndByModeAndinterrogationIdIninterrogationIdList(String campaignName, Mode mode, List<String> interrogationIdList); | ||
|
|
||
| @Query(value = "{ 'interrogationId': ?0}") | ||
| List<LunaticJsonRawDataDocument> findByInterrogationId(String interrogationId); |
Contributor
There was a problem hiding this comment.
todo: add @indexed to interrogationId in LunaticJsonRawDataDocument
| @Slf4j | ||
| public class CombinedRawDataService { | ||
|
|
||
| @Qualifier("lunaticJsonMongoAdapterNew") |
Contributor
There was a problem hiding this comment.
note: qualifier is used in the case we have differents beans implementing the same interface, it's not the case here during normal functionning for now but we put it in case we add another implementation.
suggestion: No implem has this qualifier. Rename it to "lunaticJsonMongoAdapter" to correspond with the mongo adapter qualifier
| @PreAuthorize("hasAnyRole('ADMIN', 'USER_PLATINE')") | ||
| public ResponseEntity<CombinedRawData> getCombinetRawData( | ||
| @RequestParam(INTERROGATION_ID) String interrogationId | ||
| ){CombinedRawData data = combinedRawDataService.getCombinedRawDataByInterrogationId(interrogationId); |
Contributor
There was a problem hiding this comment.
suggestion: Use a DTO to be sure on what to return
alicela
approved these changes
Jan 5, 2026
| private static final String INTERROGATION_ID = "interrogationId"; | ||
| private final CombinedRawDataService combinedRawDataService; | ||
|
|
||
| public CombinedRawDataController(CombinedRawDataService combinedRawDataService) { |
| @Qualifier("rawResponseMongoAdapter") | ||
| private final RawResponsePersistencePort rawResponsePersistencePort; | ||
|
|
||
| public CombinedRawDataService(LunaticJsonRawDataPersistencePort lunaticJsonRawDataPersistencePort, RawResponsePersistencePort rawResponsePersistencePort) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new endpoint to retrieve combined raw responses and Lunatic JSON raw data by interrogationId.