Feature/local datetime support#498
Closed
Hajarel-moukh wants to merge 13 commits into
Closed
Conversation
loichenninger
approved these changes
Jun 18, 2026
Hajarel-moukh
force-pushed
the
feature/local-datetime-support
branch
from
7cf2c44 to
cdbb118
Compare
alexisszmundy
requested changes
Jul 1, 2026
alexisszmundy
left a comment
alexisszmundy
left a comment
Contributor
There was a problem hiding this comment.
J'ai l'impression qu'il y a bcp de régressions sur springboot4, le modèle filière et Jackson
Contributor
There was a problem hiding this comment.
issue: on doit utilise la dernière version du modèle filière
| import tools.jackson.databind.JsonNode; | ||
| import tools.jackson.databind.node.ArrayNode; | ||
| import tools.jackson.databind.node.ObjectNode; | ||
| import com.fasterxml.jackson.databind.JsonNode; |
Contributor
There was a problem hiding this comment.
issue: c'est du Jackson 2
|
|
||
| if (value != null && !value.isEmpty()) { | ||
| convertOneVar(variableEntry, value, variablesMap, iteration, destination); | ||
| if (!values.isEmpty()) { |
Contributor
There was a problem hiding this comment.
nitpick: ça ne fait rien si values est vide
suggestion: return if values empty
| class LunaticModelControllerIT extends IntegrationTestAbstract { | ||
|
|
||
| @MockitoBean | ||
| @Mock |
Contributor
There was a problem hiding this comment.
question: pourquoi ne plus utiliser de mockbeans ?
| package fr.insee.genesis.controller.rest; | ||
|
|
||
| import tools.jackson.databind.ObjectMapper; | ||
| import com.fasterxml.jackson.databind.ObjectMapper; |
|
|
||
| import tools.jackson.core.JacksonException; | ||
| import tools.jackson.databind.ObjectMapper; | ||
| import com.fasterxml.jackson.core.JsonProcessingException; |
Contributor
There was a problem hiding this comment.
issue: régression sur gitIgnore
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.