Skip to content

Fix local backend trial cleanup#13

Open
VincentG1234 wants to merge 1 commit intomainfrom
fix/local-backend-cleanup
Open

Fix local backend trial cleanup#13
VincentG1234 wants to merge 1 commit intomainfrom
fix/local-backend-cleanup

Conversation

@VincentG1234
Copy link
Copy Markdown
Collaborator

Summary

  • improve local backend cleanup by tracking trial controllers alongside futures
  • request cooperative cancellation before forcing resource cleanup
  • wait briefly for running local trials to stop before clearing backend state

Why

The previous local cleanup path only cancelled futures, which is not enough when trial work is already running. This change makes shutdown and cleanup more reliable by propagating cancellation to the trial controller and attempting resource cleanup for still-running trials.

Signed-off-by: Vincent Gimenes <vincent.gimenes@gmail.com>
@VincentG1234
Copy link
Copy Markdown
Collaborator Author

@hgsmn tell me If that fix the bug you met

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant