[IDE] Milvus and ChromDB discovery (#218)

* [IDE] Mounting Milvus secret in Python IDE + adding latest library-chart with NOTES

* [IDE] Update default values for milvus discovery

Author: Gaspi

charts/jupyter-pyspark/Chart.yaml

@@ -24,8 +24,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-
-version: 2.3.1
+version: 2.3.2
 dependencies:
   - name: library-chart
     version: 1.7.0

charts/jupyter-pyspark/templates/secret-milvus.yaml

@@ -0,0 +1 @@
+{{ include "library-chart.secretMilvus" . }}

charts/jupyter-pyspark/templates/statefulset.yaml

@@ -47,6 +47,9 @@ spec:
         {{- if not (empty (trim (include "library-chart.secretChromaDB" .))) }}
         checksum/chromadb: {{ include (print $.Template.BasePath "/secret-chromadb.yaml") . | sha256sum }}
         {{- end }}
+        {{- if not (empty (trim (include "library-chart.secretMilvus" .))) }}
+        checksum/milvus: {{ include (print $.Template.BasePath "/secret-milvus.yaml") . | sha256sum }}
+        {{- end }}
         {{- if (include "library-chart.repository.enabled"  .) }}
         checksum/repository: {{ include (print $.Template.BasePath "/configmap-repository.yaml") . | sha256sum }}
         {{- end }}
@@ -278,6 +281,10 @@ spec:
             - secretRef:
                 name: {{ include "library-chart.secretNameChromaDB" . }}
             {{- end }}
+            {{- if not (empty (trim (include "library-chart.secretMilvus" .))) }}
+            - secretRef:
+                name: {{ include "library-chart.secretNameMilvus" . }}
+            {{- end }}
             {{- if .Values.extraEnvVars }}
             - secretRef:
                 name: {{ include "library-chart.secretNameExtraEnv" . }}

charts/jupyter-pyspark/values.schema.json

@@ -651,6 +651,16 @@
           "title": "Discover Metaflow services",
           "type": "boolean",
           "default": true
+        },
+        "chromadb": {
+          "title": "Discover ChromaDB services",
+          "type": "boolean",
+          "default": true
+        },
+        "milvus": {
+          "title": "Discover Milvus services",
+          "type": "boolean",
+          "default": true
         }
       }
     },

charts/jupyter-pyspark/values.yaml

@@ -115,6 +115,7 @@ discovery:
   mlflow: true
   metaflow: true
   chromadb: true
+  milvus: true
 
 hive:
   secretName: ""
@@ -128,6 +129,9 @@ metaflow:
 chromadb:
   secretName: ""
 
+milvus:
+  secretName: ""
+
 coresite:
   secretName: ""
 

charts/jupyter-python/Chart.yaml

@@ -22,7 +22,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 2.3.2
+version: 2.3.3
 dependencies:
   - name: library-chart
     version: 1.7.0

charts/jupyter-python/templates/secret-milvus.yaml

@@ -0,0 +1 @@
+{{ include "library-chart.secretMilvus" . }}

charts/jupyter-python/templates/statefulset.yaml

@@ -41,6 +41,9 @@ spec:
         {{- if not (empty (trim (include "library-chart.secretChromaDB" .))) }}
         checksum/chromadb: {{ include (print $.Template.BasePath "/secret-chromadb.yaml") . | sha256sum }}
         {{- end }}
+        {{- if not (empty (trim (include "library-chart.secretMilvus" .))) }}
+        checksum/milvus: {{ include (print $.Template.BasePath "/secret-milvus.yaml") . | sha256sum }}
+        {{- end }}
         {{- if (include "library-chart.repository.enabled"  .) }}
         checksum/repository: {{ include (print $.Template.BasePath "/configmap-repository.yaml") . | sha256sum }}
         {{- end }}
@@ -229,6 +232,10 @@ spec:
             - secretRef:
                 name: {{ include "library-chart.secretNameChromaDB" . }}
             {{- end }}
+            {{- if not (empty (trim (include "library-chart.secretMilvus" .))) }}
+            - secretRef:
+                name: {{ include "library-chart.secretNameMilvus" . }}
+            {{- end }}
             {{- if .Values.extraEnvVars }}
             - secretRef:
                 name: {{ include "library-chart.secretNameExtraEnv" . }}

charts/jupyter-python/values.schema.json

@@ -604,6 +604,16 @@
           "title": "Discover Metaflow services",
           "type": "boolean",
           "default": true
+        },
+        "chromadb": {
+          "title": "Discover ChromaDB services",
+          "type": "boolean",
+          "default": true
+        },
+        "milvus": {
+          "title": "Discover Milvus services",
+          "type": "boolean",
+          "default": true
         }
       }
     },

charts/jupyter-python/values.yaml

@@ -85,6 +85,7 @@ discovery:
   mlflow: true
   metaflow: true
   chromadb: true
+  milvus: true
 
 hive:
   secretName: ""
@@ -98,6 +99,9 @@ metaflow:
 chromadb:
   secretName: ""
 
+milvus:
+  secretName: ""
+
 coresite:
   secretName: ""