[library-chart] Add support for Path type override#247
Merged
Conversation
Allow path to be overriden
Contributor
|
Thanks for the pr. It will take effect once the other charts use this library chart version indeed. Renovate will soon open a pr to this end. I'm on it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Following InseeFrLab/onyxia#996 in the aim of making Onyxia able -for some services- to handle path-type URL instead of sub-domain, we're trying to override dynamically inject the path in the ide/ingress.json (https://github.com/InseeFrLab/onyxia-api/blob/b47eece8103fa6bc78302390b3f0b8570de9e494/onyxia-api/src/main/resources/schemas/ide/ingress.json#L31).
However since the variable does not exists in your charts i believe it will not work prior to this change.
Checklist
Chart.yaml