feat: add marimo-python chart#313
Conversation
There was a problem hiding this comment.
Let's remove this for now. This should be adressed at a later time. (All I see so far is configuration for continue plugin extension which is vscode' specific)
| secretName: {{ include "library-chart.secretNameCacerts" . }} | ||
| {{- end }} | ||
| {{- if (.Values.userPreferences.aiAssistant).enabled }} | ||
| - name: secret-assistant |
There was a problem hiding this comment.
let's remove this for now as we the assistant is not properly configured yet
| echo 'initContainer make-secrets-writable is started'; | ||
| {{ if (.Values.userPreferences.aiAssistant).enabled }} | ||
| mkdir /dest/continue | ||
| cp /src/continue/config.yaml /dest/continue/config.yaml |
There was a problem hiding this comment.
It makes no sense to have continue configuration file here as it is specific to vscode
| awk 'BEGIN {c=0;} /BEGIN CERT/{c++} { print > "/dest/cacerts/cert." c ".crt"}' < /tmp/ca.pem; | ||
| {{- end }} | ||
| volumeMounts: | ||
| {{- if (.Values.userPreferences.aiAssistant).enabled }} |
There was a problem hiding this comment.
same here, for now, let's remove anything related to aissistant (or the subject needs to be adressed properly : which file should be modified for the configuration to take effect ? are env. variables enough ? )
| {{- end }} | ||
| resources: | ||
| limits: | ||
| cpu: 50m |
There was a problem hiding this comment.
This needs to be parameterized
| image: "inseefrlab/onyxia-base:latest" | ||
| pullPolicy: IfNotPresent | ||
| image: | ||
| version: "pacordonnier/marimo-python:py3.13.12" |
There was a problem hiding this comment.
we should use inseefrlab images
| userPreferences: | ||
| darkMode: false | ||
| language: "en" | ||
| aiAssistant: |
There was a problem hiding this comment.
this should be removed for now
| - name: ROOT_PROJECT_DIRECTORY | ||
| value: /home/{{ .Values.environment.user }}/work | ||
| {{- if .Values.userPreferences.darkMode }} | ||
| - name: DARK_MODE |
There was a problem hiding this comment.
If it is configurable, we should make use of it when creating the image : https://github.com/InseeFrLab/images-datascience/blob/01d4fa974b3ca389a18b3e7ecb35632efebbfbaa/base/scripts/onyxia-init.sh#L152
Else, it should be removed
| mountPath: /home/{{ .Values.environment.user }}/.token | ||
| readOnly: true | ||
| {{ if (.Values.userPreferences.aiAssistant).enabled }} | ||
| - mountPath: /home/{{ .Values.environment.user }}/.continue |
There was a problem hiding this comment.
This is specific to vscode and therefore should be removed
| - https://github.com/InseeFrLab/images-datascience | ||
| - https://github.com/InseeFrLab/helm-charts-interactive-services | ||
| type: application | ||
| version: 0.0.4 |
There was a problem hiding this comment.
Maybe we can start at version 1.0.0 or 0.1.0
|
Thank you for the PR @PACordonnier |
|
thanks for the review, i will push the modification quickly |
2 participants
Description of the change
The PR aims to add Marimo as python env exclusively. It is a subset of PR #312.
I've made a more readable commit history. A commit having the change from vscode-python to marimo-python exists (67643b7) and is meant to highlight the changes made from vscode to marimo.
(Following text is copied from #312)
Changes:
Marimo does not support reading token/password from ENV, so needs to mount the secret-token as volumes
In statefulset.yaml, args are now:
volume for secret token needs to be declared in statefulset.yaml
volumeMounts:
Checklist
Chart.yaml