Skip to content

Commit e752f2a

Browse files
committed
use @ReadOnlyComposable wherever possible
1 parent 461b568 commit e752f2a

6 files changed

Lines changed: 14 additions & 10 deletions

File tree

projects/compose/koin-compose/src/androidMain/kotlin/org/koin/compose/KoinApplication.android.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import android.content.ComponentCallbacks
55
import android.content.Context
66
import android.content.ContextWrapper
77
import androidx.compose.runtime.Composable
8+
import androidx.compose.runtime.ReadOnlyComposable
89
import androidx.compose.runtime.remember
910
import org.koin.dsl.KoinConfiguration
1011
import androidx.compose.ui.platform.LocalContext
@@ -17,7 +18,7 @@ import org.koin.core.logger.Level
1718
import org.koin.dsl.koinConfiguration
1819
import org.koin.dsl.includes
1920

20-
@Composable
21+
@Composable @ReadOnlyComposable
2122
internal actual fun composeMultiplatformConfiguration(loggerLevel : Level, config : KoinConfiguration) : KoinConfiguration {
2223
val appContext = LocalContext.current.applicationContext ?: error("Android ApplicationContext not found in current Compose context!")
2324
return koinConfiguration {

projects/compose/koin-compose/src/commonMain/kotlin/org/koin/compose/KoinApplication.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import androidx.compose.runtime.Composable
2020
import androidx.compose.runtime.CompositionLocalProvider
2121
import androidx.compose.runtime.InternalComposeApi
2222
import androidx.compose.runtime.ProvidableCompositionLocal
23+
import androidx.compose.runtime.ReadOnlyComposable
2324
import androidx.compose.runtime.compositionLocalOf
2425
import androidx.compose.runtime.currentComposer
2526
import org.koin.compose.application.rememberKoinApplication
@@ -61,7 +62,7 @@ private fun getDefaultRootScope() = KoinPlatform.getKoin().scopeRegistry.rootSco
6162
* @author @author jjkester
6263
*/
6364
@OptIn(InternalComposeApi::class, KoinInternalApi::class)
64-
@Composable
65+
@Composable @ReadOnlyComposable
6566
fun getKoin(): Koin = currentComposer.run {
6667
try {
6768
consume(LocalKoinApplication).getValue()
@@ -78,7 +79,7 @@ fun getKoin(): Koin = currentComposer.run {
7879
*
7980
*/
8081
@OptIn(InternalComposeApi::class, KoinInternalApi::class)
81-
@Composable
82+
@Composable @ReadOnlyComposable
8283
fun currentKoinScope(): Scope = currentComposer.run {
8384
try {
8485
val currentScope = consume(LocalKoinScope).getValue()
@@ -154,6 +155,7 @@ fun KoinMultiplatformApplication(
154155
* - Help handle automatically Android Logger Anticipate Android context injection, to having to setup androidContext() and androidLogger
155156
*/
156157
@Composable
158+
@ReadOnlyComposable
157159
@PublishedApi
158160
@KoinInternalApi
159161
internal expect fun composeMultiplatformConfiguration(

projects/compose/koin-compose/src/jsMain/kotlin/org/koin/compose/KoinApplication.js.kt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package org.koin.compose
22

33
import androidx.compose.runtime.Composable
4+
import androidx.compose.runtime.ReadOnlyComposable
45
import org.koin.core.Koin
5-
import org.koin.core.KoinApplication
66
import org.koin.core.annotation.KoinExperimentalAPI
77
import org.koin.dsl.KoinConfiguration
88
import org.koin.core.logger.Level
@@ -11,6 +11,7 @@ import org.koin.dsl.includes
1111
import org.koin.mp.KoinPlatform
1212

1313
@Composable
14+
@ReadOnlyComposable
1415
@KoinExperimentalAPI
1516
internal actual fun composeMultiplatformConfiguration(loggerLevel : Level, config : KoinConfiguration) : KoinConfiguration {
1617
return koinConfiguration {

projects/compose/koin-compose/src/jvmMain/kotlin/org/koin/compose/KoinApplication.jvm.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
package org.koin.compose
22

33
import androidx.compose.runtime.Composable
4+
import androidx.compose.runtime.ReadOnlyComposable
45
import org.koin.core.Koin
5-
import org.koin.core.KoinApplication
66
import org.koin.dsl.KoinConfiguration
77
import org.koin.core.logger.Level
88
import org.koin.dsl.koinConfiguration
99
import org.koin.dsl.includes
1010
import org.koin.mp.KoinPlatform
1111

12-
@Composable
12+
@Composable @ReadOnlyComposable
1313
internal actual fun composeMultiplatformConfiguration(loggerLevel : Level, config : KoinConfiguration) : KoinConfiguration {
1414
return koinConfiguration {
1515
printLogger(loggerLevel)

projects/compose/koin-compose/src/nativeMain/kotlin/org/koin/compose/KoinApplication.native.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
package org.koin.compose
22

33
import androidx.compose.runtime.Composable
4+
import androidx.compose.runtime.ReadOnlyComposable
45
import org.koin.core.Koin
5-
import org.koin.core.KoinApplication
66
import org.koin.dsl.KoinConfiguration
77
import org.koin.core.logger.Level
88
import org.koin.dsl.koinConfiguration
99
import org.koin.dsl.includes
1010
import org.koin.mp.KoinPlatform
1111

12-
@Composable
12+
@Composable @ReadOnlyComposable
1313
internal actual fun composeMultiplatformConfiguration(loggerLevel : Level, config : KoinConfiguration) : KoinConfiguration {
1414
return koinConfiguration {
1515
printLogger(loggerLevel)

projects/compose/koin-compose/src/wasmJsMain/kotlin/org/koin/compose/KoinApplication.wasmJS.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
package org.koin.compose
22

33
import androidx.compose.runtime.Composable
4+
import androidx.compose.runtime.ReadOnlyComposable
45
import org.koin.core.Koin
5-
import org.koin.core.KoinApplication
66
import org.koin.dsl.KoinConfiguration
77
import org.koin.core.logger.Level
88
import org.koin.dsl.koinConfiguration
99
import org.koin.dsl.includes
1010
import org.koin.mp.KoinPlatform
1111

12-
@Composable
12+
@Composable @ReadOnlyComposable
1313
internal actual fun composeMultiplatformConfiguration(loggerLevel : Level, config : KoinConfiguration) : KoinConfiguration {
1414
return koinConfiguration {
1515
printLogger(loggerLevel)

0 commit comments

Comments
 (0)