Skip to content

Use @ReadOnlyComposable wherever possible #2375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Miha-x64 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use @ReadOnlyComposable wherever possible #2375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...s/compose/koin-compose/src/androidMain/kotlin/org/koin/compose/KoinApplication.android.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import android.content.ComponentCallbacks
import android.content.Context
import android.content.ContextWrapper
import androidx.compose.runtime.Composable
import androidx.compose.runtime.ReadOnlyComposable
import androidx.compose.runtime.remember
import org.koin.dsl.KoinConfiguration
import androidx.compose.ui.platform.LocalContext
Expand All @@ -18,6 +19,7 @@ import org.koin.dsl.koinConfiguration
import org.koin.dsl.includes

@Composable
@ReadOnlyComposable
internal actual fun composeMultiplatformConfiguration(loggerLevel : Level, config : KoinConfiguration) : KoinConfiguration {
val appContext = LocalContext.current.applicationContext ?: error("Android ApplicationContext not found in current Compose context!")
return koinConfiguration {
Expand Down
4 changes: 4 additions & 0 deletions projects/compose/koin-compose/src/commonMain/kotlin/org/koin/compose/KoinApplication.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.runtime.CompositionLocalProvider
import androidx.compose.runtime.InternalComposeApi
import androidx.compose.runtime.ProvidableCompositionLocal
import androidx.compose.runtime.ReadOnlyComposable
import androidx.compose.runtime.compositionLocalOf
import androidx.compose.runtime.currentComposer
import org.koin.compose.application.rememberKoinApplication
Expand Down Expand Up @@ -62,6 +63,7 @@ private fun getDefaultRootScope() = KoinPlatform.getKoin().scopeRegistry.rootSco
*/
@OptIn(InternalComposeApi::class, KoinInternalApi::class)
@Composable
@ReadOnlyComposable
fun getKoin(): Koin = currentComposer.run {
try {
consume(LocalKoinApplication).getValue()
Expand All @@ -79,6 +81,7 @@ fun getKoin(): Koin = currentComposer.run {
*/
@OptIn(InternalComposeApi::class, KoinInternalApi::class)
@Composable
@ReadOnlyComposable
fun currentKoinScope(): Scope = currentComposer.run {
try {
val currentScope = consume(LocalKoinScope).getValue()
Expand Down Expand Up @@ -154,6 +157,7 @@ fun KoinMultiplatformApplication(
* - Help handle automatically Android Logger Anticipate Android context injection, to having to setup androidContext() and androidLogger
*/
@Composable
@ReadOnlyComposable
@PublishedApi
@KoinInternalApi
internal expect fun composeMultiplatformConfiguration(
Expand Down
3 changes: 2 additions & 1 deletion projects/compose/koin-compose/src/jsMain/kotlin/org/koin/compose/KoinApplication.js.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package org.koin.compose

import androidx.compose.runtime.Composable
import androidx.compose.runtime.ReadOnlyComposable
import org.koin.core.Koin
import org.koin.core.KoinApplication
import org.koin.core.annotation.KoinExperimentalAPI
import org.koin.dsl.KoinConfiguration
import org.koin.core.logger.Level
Expand All @@ -11,6 +11,7 @@ import org.koin.dsl.includes
import org.koin.mp.KoinPlatform

@Composable
@ReadOnlyComposable
@KoinExperimentalAPI
internal actual fun composeMultiplatformConfiguration(loggerLevel : Level, config : KoinConfiguration) : KoinConfiguration {
return koinConfiguration {
Expand Down
3 changes: 2 additions & 1 deletion projects/compose/koin-compose/src/jvmMain/kotlin/org/koin/compose/KoinApplication.jvm.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
package org.koin.compose

import androidx.compose.runtime.Composable
import androidx.compose.runtime.ReadOnlyComposable
import org.koin.core.Koin
import org.koin.core.KoinApplication
import org.koin.dsl.KoinConfiguration
import org.koin.core.logger.Level
import org.koin.dsl.koinConfiguration
import org.koin.dsl.includes
import org.koin.mp.KoinPlatform

@Composable
@ReadOnlyComposable
internal actual fun composeMultiplatformConfiguration(loggerLevel : Level, config : KoinConfiguration) : KoinConfiguration {
return koinConfiguration {
printLogger(loggerLevel)
Expand Down
3 changes: 2 additions & 1 deletion ...cts/compose/koin-compose/src/nativeMain/kotlin/org/koin/compose/KoinApplication.native.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
package org.koin.compose

import androidx.compose.runtime.Composable
import androidx.compose.runtime.ReadOnlyComposable
import org.koin.core.Koin
import org.koin.core.KoinApplication
import org.koin.dsl.KoinConfiguration
import org.koin.core.logger.Level
import org.koin.dsl.koinConfiguration
import org.koin.dsl.includes
import org.koin.mp.KoinPlatform

@Composable
@ReadOnlyComposable
internal actual fun composeMultiplatformConfiguration(loggerLevel : Level, config : KoinConfiguration) : KoinConfiguration {
return koinConfiguration {
printLogger(loggerLevel)
Expand Down
3 changes: 2 additions & 1 deletion ...cts/compose/koin-compose/src/wasmJsMain/kotlin/org/koin/compose/KoinApplication.wasmJS.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
package org.koin.compose

import androidx.compose.runtime.Composable
import androidx.compose.runtime.ReadOnlyComposable
import org.koin.core.Koin
import org.koin.core.KoinApplication
import org.koin.dsl.KoinConfiguration
import org.koin.core.logger.Level
import org.koin.dsl.koinConfiguration
import org.koin.dsl.includes
import org.koin.mp.KoinPlatform

@Composable
@ReadOnlyComposable
internal actual fun composeMultiplatformConfiguration(loggerLevel : Level, config : KoinConfiguration) : KoinConfiguration {
return koinConfiguration {
printLogger(loggerLevel)
Expand Down